From: Benjamin Marzinski <bmarzins@redhat.com>
To: Martin Wilck <mwilck@suse.com>
Cc: dm-devel mailing list <dm-devel@redhat.com>,
Xose Vazquez Perez <xose.vazquez@gmail.com>,
chris@hofstaedtler.name
Subject: Re: [dm-devel] multipath-tools: Debian patches
Date: Tue, 6 Jun 2023 11:15:40 -0500 [thread overview]
Message-ID: <20230606161540.GZ24096@octiron.msp.redhat.com> (raw)
In-Reply-To: <946fc11571491dd39971288b48095b6480f7914f.camel@suse.com>
On Tue, Jun 06, 2023 at 05:18:36PM +0200, Martin Wilck wrote:
> On Mon, 2023-06-05 at 21:59 +0200, Xose Vazquez Perez wrote:
> > Hi,
> >
>
> I have no Debian salsa account, so I reply here, trying to reach Chris
> via email.
>
> >
> > A complaint about upstream, "Remove library development files and all
> > of libdmmp":
> > https://salsa.debian.org/linux-blocks-team/multipath-tools/-/commit/8c46661697d757763192d8e011c9ad53358d20b7
>
> If Chris has followed the upstream discussion, he is probably aware
> that we do care about the ABI. We don't keep the libmultipath ABI
> stable, but track it using ABI versioning. It is true that most of the
> libmultipath headers are not used for other projects. Not installing
> any headers except the public ones makes sense, actually.
>
> The libmpathpersist API (LIBMPATHPERSIST_2.1.0) that's used by qemu is
> supposed to remain stable. We have moved those parts of the ABI that
> used to be more volatile into __LIBMPATHPERSIST_INT_1.0.0.
>
> Therefore it makes sense to keep shipping mpath_persist.h and drop the
> rest. If that works for Debian, it will probably work for other
> distros, too.
>
> libdmpp comes from Red Hat, perhaps Ben knows whether it is still used
> by any alive project. It does have a stable API/ABI.
>
I don't know of any users, but I don't feel confident in saying that
there aren't any, and I agree that it's ABI is stable.
libmpathvalid has a stable API/ABI as well.
So does libmpathcmd. That one doesn't even have any connection to
libmultipath in the library itself. It's just sockets.
-Ben
> > And maybe these are relevant for upstream ( repo:
> > https://salsa.debian.org/linux-blocks-team/multipath-tools/-/tree/master/debian/patches
> > ):
> >
> > https://udd.debian.org/patches.cgi?src=multipath-tools&version=0.9.4-3
> >
>
> That's not how we work. We don't pick downstream patches. If
> something's wrong with the upstream code, we'll happily discuss patches
> from the Debian project, preferably here on dm-devel.
>
> Regards
> Martin
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2023-06-06 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a674434b-d365-1f07-2c6f-6a4ffa07578f@gmail.com>
2023-06-06 15:18 ` [dm-devel] multipath-tools: Debian patches Martin Wilck
2023-06-06 16:15 ` Benjamin Marzinski [this message]
2023-06-06 16:48 ` Chris Hofstaedtler
2023-06-06 19:21 ` Martin Wilck
2023-06-07 15:12 ` Chris Hofstaedtler
2023-06-15 17:11 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606161540.GZ24096@octiron.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=chris@hofstaedtler.name \
--cc=dm-devel@redhat.com \
--cc=mwilck@suse.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).