From: Jens Axboe <axboe@kernel.dk>
To: Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-block@vger.kernel.org, Chris Mason <clm@fb.com>,
dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: limits->max_sectors is getting set to 0, why/where? [was: Re: dm: kernel oops by divide error on v4.16+]
Date: Mon, 9 Apr 2018 17:01:34 -0600 [thread overview]
Message-ID: <24e7093b-ba3a-9f0d-4c5b-572862a6c622@kernel.dk> (raw)
In-Reply-To: <CAGXu5jJD0b15a2yBUEiTT=Kjy2cLTVWCqhsnVZu5aKf-ieyZ+A@mail.gmail.com>
On 4/9/18 4:38 PM, Kees Cook wrote:
> On Mon, Apr 9, 2018 at 3:32 PM, Jens Axboe <axboe@kernel.dk> wrote:
>> That's bad, for sure, but my worry was bigger than an oops or crash,
>> we could have had corruption due to this.
>>
>> The resulting min/max and friends would have been trivial to test, but
>> clearly they weren't.
>
> Yeah, that was bad luck and my fault: I tested min(), max(), min_t(),
It's only bad luck if it was tested :-)
> and max_t(). My assumption was that since the others were built from
> them, they'd be fine. Not true in this shadow variable case, though.
> :( We could do something like this, which would have caught it:
Might not hurt to do.
--
Jens Axboe
next prev parent reply other threads:[~2018-04-09 23:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 4:00 dm: kernel oops by divide error on v4.16+ Ming Lei
2018-04-09 15:51 ` limits->max_sectors is getting set to 0, why/where? [was: Re: dm: kernel oops by divide error on v4.16+] Mike Snitzer
2018-04-09 18:38 ` Mike Snitzer
2018-04-09 19:32 ` Jens Axboe
2018-04-09 21:26 ` Jens Axboe
2018-04-09 21:56 ` Jens Axboe
2018-04-09 22:05 ` Kees Cook
2018-04-09 22:10 ` Jens Axboe
2018-04-09 22:27 ` Ming Lei
2018-04-09 22:32 ` Jens Axboe
2018-04-09 22:38 ` Kees Cook
2018-04-09 23:01 ` Jens Axboe [this message]
2018-04-09 23:54 ` Linus Torvalds
2018-04-10 0:31 ` Jens Axboe
2018-04-09 22:11 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24e7093b-ba3a-9f0d-4c5b-572862a6c622@kernel.dk \
--to=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=dm-devel@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox