Linux Device Mapper development
 help / color / mirror / Atom feed
From: Martin George <marting@netapp.com>
To: Christophe Varoqui <christophe.varoqui@gmail.com>
Cc: device-mapper development <dm-devel@redhat.com>,
	Xose Vazquez Perez <xose.vazquez@gmail.com>
Subject: [PATCH] multipath-tools: Remove NetApp IBM Nseries code
Date: Mon, 11 Jul 2016 01:55:36 +0530	[thread overview]
Message-ID: <2927779.USFptljH3X@marting-ubuntu> (raw)

Remove the NetApp IBM Nseries code due to the following reasons:

1) The NetApp IBM Nseries product is obsolete now.

2) Even earlier, the NetApp IBM Nseries product line never used a
VID/PID of "IBM" & "Nseries" respectively. Instead, it always
used the same VID/PID of "NETAPP" & "LUN" itself, similar to the
ONTAP product line. So this piece of code was redundant from the
beginning itself.

Signed-off-by: Martin George <marting@netapp.com>
---
 libmultipath/hwtable.c     | 14 --------------
 multipath/multipath.conf.5 |  2 +-
 2 files changed, 1 insertion(+), 15 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index a89ea87..140e802 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -770,20 +770,6 @@ static struct hwentry default_hw[] = {
 		.retain_hwhandler = RETAIN_HWHANDLER_ON,
 		.detect_prio   = DETECT_PRIO_ON,
 	},
-	{
-		/* IBM NSeries */
-		.vendor        = "IBM",
-		.product       = "Nseries.*",
-		.features      = "1 queue_if_no_path",
-		.hwhandler     = DEFAULT_HWHANDLER,
-		.pgpolicy      = GROUP_BY_PRIO,
-		.pgfailback    = -FAILBACK_IMMEDIATE,
-		.rr_weight     = RR_WEIGHT_NONE,
-		.no_path_retry = NO_PATH_RETRY_UNDEF,
-		.minio         = 128,
-		.prio_name     = PRIO_ONTAP,
-		.prio_args     = NULL,
-	},
 	/*
 	 * NEXENTA
 	 *
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index 709ab3c..0b4d366 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -224,7 +224,7 @@ accepts the optional prio_arg \fIexclusive_pref_bit\fR.
 .TP
 .I ontap
 (Hardware-dependent)
-Generate the path priority for NetApp ONTAP class and OEM arrays as IBM NSeries.
+Generate the path priority for NetApp ONTAP class arrays.
 .TP
 .I rdac
 (Hardware-dependent)
-- 
1.9.1

             reply	other threads:[~2016-07-10 20:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-10 20:25 Martin George [this message]
2016-07-12  2:00 ` [PATCH] multipath-tools: Remove NetApp IBM Nseries code Xose Vazquez Perez
2016-07-12 16:28   ` Martin George

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2927779.USFptljH3X@marting-ubuntu \
    --to=marting@netapp.com \
    --cc=christophe.varoqui@gmail.com \
    --cc=dm-devel@redhat.com \
    --cc=xose.vazquez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox