From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Wilck Subject: Re: [PATCH v2 12/12] multipathd: change failed get_uid handling Date: Fri, 15 Mar 2019 12:50:14 +0100 Message-ID: <2dca5572b832888c9494e102ccebf14dce320155.camel@suse.com> References: <1552086725-18476-1-git-send-email-bmarzins@redhat.com> <1552086725-18476-13-git-send-email-bmarzins@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1552086725-18476-13-git-send-email-bmarzins@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Benjamin Marzinski , Christophe Varoqui Cc: device-mapper development List-Id: dm-devel.ids T24gRnJpLCAyMDE5LTAzLTA4IGF0IDE3OjEyIC0wNjAwLCBCZW5qYW1pbiBNYXJ6aW5za2kgd3Jv dGU6Cj4gSW5zdGVhZCBvZiBpZ25vcmluZyBmYWlsZWQgZ2V0X3VpZCgpIGNhbGxzLCBtdWx0aXBh dGhkIG5vdyBmYWlscyB0aGUKPiBwYXRoIGFzIGl0IG9yaWdpbmFsbHkgZGlkLgoKVGhpcyBwYXRj aCByZXZlcnRzIG11Y2ggb2YgMDcvMTI7IEknZCBhcHByZWNpYXRlIGlmIHlvdSBjb3VsZCBtZXJn ZSB0aGUKdHdvIGludG8gb25lLCB0aGF0IHdvdWxkIG1ha2UgdGhlIHJldmlldyBlYXNpZXIuCgo+ IEhvd2V2ZXIsIGlmIHRoZSByZXN1bHQgb2YgY2FsbGluZyBnZXRfdWlkKCkKPiBpcyBhIGJsYW5r IHd3aWQgKHdoaWNoIGlzIGFsd2F5cyB0aGUgY2FzZSB3aGVuIGl0IGZhaWxzKSwgbXVsdGlwYXRo ZAo+IG5vdwo+IHRyaWVzIHRvIGdldCB0aGUgd3dpZCBpbiBjaGVja19wYXRoKCkgYXMgd2VsbCwg dXNpbmcgdGhlCj4gdWlkX2ZhbGxiYWNrKCkKPiBtZXRob2RzIHRvIGF0dGVtcHQgdG8gZ2V0IGEg dmFsaWQgd3dpZC4KPiAKPiBNdWx0aXBhdGhkIGNhbid0IHVzZSB0aGUgdWlkX2F0dHJpYnV0ZSBt ZXRob2RzLCBzaW5jZSBwcC0+dWRldiBzdGlsbAo+IGhhcwo+IHRoZSBvbGQgdWV2ZW50IGluZm9y bWF0aW9uIHdpdGggdGhlIHVpZF9hdHRyaWJ1dGUgb2YgdGhlIG9yaWdpbmFsCj4gd3dpZC4KCldo aWNoIGlzIGFjdHVhbGx5IHdyb25nLCBJTU8uIEl0IG1lYW5zIHRoYXQgdWRldidzIChhbmQgdGhl IGtlcm5lbCdzKQp2aWV3IG9mIHRoZSBkZXZpY2UgYXJlIG5vdyBkaWZmZXJlbnQgZnJvbSBtdWx0 aXBhdGhkJ3MsIGFuZCB3aWxsIHJlbWFpbgpzbyB1bmxlc3MgYSBuZXcgY2hhbmdlIGV2ZW50IGFy cml2ZXMuIFdoYXQgYmFkIGNhbiBoYXBwZW4gaWYgd2UgdXBkYXRlCnBwLT51ZGV2PwoKUGVyaGFw cyB3ZSBzaG91bGQgcmF0aGVyIHVwZGF0ZSBwcC0+dWRldiBhbHdheXMsIGFuZCBzZXQgdGhlCnd3 aWRfY2hhbmdlZCBmbGFnIGlmIG5lY2Vzc2FyeS4gVGhlIGNhc2Ugd3dpZF9jaGFuZ2VkPT1XV0lE X1pFUk9FRApjb3VsZCBiZSB0cmVhdGVkIGxpa2UgSU5JVF9NSVNTSU5HX1VERVYgKGl0IF9pc18g YWxtb3N0IHRoZSBzYW1lIGNhc2UsCmFjdHVhbGx5KSwgYnkgcmV0cmlnZ2VyaW5nIHVldmVudHMu Cgo+IFRoaXMgbWVhbnMgdGhhdCB0aGUgdWlkX2F0dHJpYnV0ZSBtZXRob2RzIHdvdWxkIGFsd2F5 cyByZXR1cm4gdGhlCj4gb3JpZ2luYWwgd3dpZCwgZXZlbiBpZiBpdCBoYWQgY2hhbmdlZC4KPiAK PiBUbyBtYWtlIHRoZSBnZXRfdWlkKCkgdXNlIHRoZSBmYWxsYmFjayBtZXRob2RzLCBwYXRoaW5m byBub3cgc2V0cwo+IHBwLT5yZXRyaWdnZXJzIHRvIHRoZSByZXRyaWdnZXJfdHJpZXMgb25jZSBh IFdXSUQgaGFzIGJlIHN1Y2Nlc3NmdWxseQo+IG9idGFpbmVkLCBzbyB0aGF0IGl0IHVpZF9mYWxs YmFjaygpIGRvZXNuJ3QgbmVlZCB0byBiZSBjYWxsZWQKPiByZXRyaWdnZXJfdHJpZXMgdGltZXMg YmVmb3JlIHRyeWluZyB0aGUgZmFsbGJhY2sgbWV0aG9kcy4KCkkgZG9uJ3QgbGlrZSB0aGlzIG11 Y2gsIHNlZSBiZWxvdy4KCgo+IFNpZ25lZC1vZmYtYnk6IEJlbmphbWluIE1hcnppbnNraSA8Ym1h cnppbnNAcmVkaGF0LmNvbT4KPiAtLS0KPiAgbGlibXVsdGlwYXRoL2Rpc2NvdmVyeS5jIHwgIDQg KysrLQo+ICBsaWJtdWx0aXBhdGgvc3RydWN0cy5oICAgfCAgNiArKysrKysKPiAgbXVsdGlwYXRo ZC9tYWluLmMgICAgICAgIHwgMzYgKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0t Cj4gIDMgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2xpYm11bHRpcGF0aC9kaXNjb3ZlcnkuYyBiL2xpYm11bHRpcGF0aC9k aXNjb3ZlcnkuYwo+IGluZGV4IGJlY2U2N2MuLjE1NTY4Y2EgMTAwNjQ0Cj4gLS0tIGEvbGlibXVs dGlwYXRoL2Rpc2NvdmVyeS5jCj4gKysrIGIvbGlibXVsdGlwYXRoL2Rpc2NvdmVyeS5jCj4gQEAg LTIwMTgsOCArMjAxOCwxMCBAQCBpbnQgcGF0aGluZm8oc3RydWN0IHBhdGggKnBwLCBzdHJ1Y3Qg Y29uZmlnCj4gKmNvbmYsIGludCBtYXNrKQo+ICAJCX0KPiAgCX0KPiAgCj4gLQlpZiAoKG1hc2sg JiBESV9BTEwpID09IERJX0FMTCkKPiArCWlmICgobWFzayAmIERJX0FMTCkgPT0gRElfQUxMKSB7 Cj4gKwkJcHAtPnJldHJpZ2dlcnMgPSBjb25mLT5yZXRyaWdnZXJfdHJpZXM7Cj4gIAkJcHAtPmlu aXRpYWxpemVkID0gSU5JVF9PSzsKPiArCX0KPiAgCXJldHVybiBQQVRISU5GT19PSzsKClRoaXMg YWJ1c2Ugb2YgcmV0cmlnZ2VyX3RyaWVzIGxvb2tzIGxpa2UgYSBoYWNrIHRvIG1lLiBZb3Ugd2Fu dAp1aWRfZmFsbGJhY2soKSB0byB0cnkgYW5kIGdldCBhIHVpZCwgZXZlbiBpZiByZXRyaWdnZXJf dHJpZXMgaXNuJ3QKZXhoYXVzdGVkLiBTbyB5b3UgeW91IHNob3VsZCBjaGVjayBhbm90aGVyIGNv bmRpdGlvbiBiZXNpZGVzIAoocmV0cmlnZ2VycyA+IHJldHJpZ2dlcnNfdHJpZXMpIGluIHVpZF9j YWxsYmFjaygpLgoKQXQgdGhlIHZlcnkgbGVhc3QsIHRoaXMgd291bGQgY2FsbCBmb3IgY29tbWVu dHMgZXhwbGFpbmluZyB0aGUgbG9naWMKaW4gYm90aCBwYXRoaW5mbygpIGFuZCB1aWRfZmFsbGJh Y2soKS4gSSB0aGluayB5b3UnZCBhbHNvIGhhdmUgdG8gc2V0IApyZXRyaWdnZXJzID0gMCB3aGVu IHlvdSBzZXQgaW5pdGlhbGl6ZWQgPSBJTklUX01JU1NJTkdfVURFVgooYmUgaXQgb25seSBmb3Ig Y29kZSBjbGFyaXR5KS4gQnV0IEknZCBwcmVmZXIgbm90IHRvIHVzZSB0aGUgcmV0cmlnZ2VyCmNv dW50ZXIgZm9yIHRoaXMgZGlmZmVyZW50IGNvbmRpdGlvbi4KCj4gWy4uLl0KPiBAQCAtMjAxNywx MCArMjAxNywyNCBAQCBjaGVja19wYXRoIChzdHJ1Y3QgdmVjdG9ycyAqIHZlY3MsIHN0cnVjdAo+ IHBhdGggKiBwcCwgaW50IHRpY2tzKQo+ICAJaWYgKG5ld3N0YXRlID09IFBBVEhfUkVNT1ZFRCkK PiAgCQluZXdzdGF0ZSA9IFBBVEhfRE9XTjsKPiAgCj4gLQlpZiAocHAtPnd3aWRfY2hhbmdlZCkg ewo+IC0JCWNvbmRsb2coMiwgIiVzOiBwYXRoIHd3aWQgaGFzIGNoYW5nZWQuIFJlZnVzaW5nIHRv Cj4gdXNlIiwKPiAtCQkJcHAtPmRldik7Cj4gLQkJbmV3c3RhdGUgPSBQQVRIX0RPV047Cj4gKwlp ZiAocHAtPnd3aWRfY2hhbmdlZCAhPSBXV0lEX1NBTUUpIHsKPiArCQlpZiAocHAtPnd3aWRfY2hh bmdlZCA9PSBXV0lEX1pFUk9FRCkgewo+ICsJCQljaGFyIHd3aWRbV1dJRF9TSVpFXTsKPiArCj4g KwkJCXN0cmNweSh3d2lkLCBwcC0+d3dpZCk7Cj4gKwkJCWdldF91aWQocHAsIG5ld3N0YXRlLCBO VUxMKTsKPiArCQkJaWYgKHN0cm5jbXAod3dpZCwgcHAtPnd3aWQsIFdXSURfU0laRSkgPT0gMCkK PiArCQkJCXBwLT53d2lkX2NoYW5nZWQgPSBXV0lEX1NBTUU7Cj4gKwkJCWVsc2Ugewo+ICsJCQkJ cHAtPnd3aWRfY2hhbmdlZCA9IChzdHJsZW4ocHAtPnd3aWQpKT8KPiBXV0lEX0NIQU5HRUQgOiBX V0lEX1pFUk9FRDsKPiArCQkJCXN0cmNweShwcC0+d3dpZCwgd3dpZCk7Cj4gKwkJCX0KPiArCQl9 Cj4gKwkJaWYgKHBwLT53d2lkX2NoYW5nZWQgIT0gV1dJRF9TQU1FKSB7Cj4gKwkJCWNvbmRsb2co MiwgIiVzOiBwYXRoIHd3aWQgaGFzIGNoYW5nZWQuIFJlZnVzaW5nCj4gdG8gdXNlIiwKPiArCQkJ CXBwLT5kZXYpOwoKUGxlYXNlIGRvbid0IGxvZyB0aGUgc2FtZSBjb25kaXRpb24gYXQgLXYyIGlu IGV2ZXJ5IGNoZWNrX3BhdGgoKQppdGVyYXRpb24uIFdlIGxvZyB0aGUgYWN0dWFsIGNoYW5nZSBh dCAtdjAgYWxyZWFkeSBpbgp1ZXZfdXBkYXRlX3BhdGgoKS4KClJlZ2FyZHMKTWFydGluCgotLSAK RHIuIE1hcnRpbiBXaWxjayA8bXdpbGNrQHN1c2UuY29tPiwgVGVsLiArNDkgKDApOTExIDc0MDUz IDIxMDcKU1VTRSBMaW51eCBHbWJILCBHRjogRmVsaXggSW1lbmTDtnJmZmVyLCBKYW5lIFNtaXRo YXJkLCBHcmFoYW0gTm9ydG9uCkhSQiAyMTI4NCAoQUcgTsO8cm5iZXJnKQoKCi0tCmRtLWRldmVs IG1haWxpbmcgbGlzdApkbS1kZXZlbEByZWRoYXQuY29tCmh0dHBzOi8vd3d3LnJlZGhhdC5jb20v bWFpbG1hbi9saXN0aW5mby9kbS1kZXZlbA==