From: SF Markus Elfring <elfring@users.sourceforge.net>
To: dm-devel@redhat.com, linux-raid@vger.kernel.org,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>, Shaohua Li <shli@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash()
Date: Thu, 29 Sep 2016 11:07:47 +0200 [thread overview]
Message-ID: <3861d349-48fd-162b-a749-83e007f70b41@users.sourceforge.net> (raw)
In-Reply-To: <080668d9-1e1e-e208-f9ea-ff718e8070e5@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 28 Sep 2016 22:20:08 +0200
* Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinelle software.
* Replace the specification of data structures by pointer dereferences
to make the corresponding size determination a bit safer according to
the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/md/dm-snap.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c
index c65feea..f262f7e 100644
--- a/drivers/md/dm-snap.c
+++ b/drivers/md/dm-snap.c
@@ -326,8 +326,9 @@ static int init_origin_hash(void)
{
int i;
- _origins = kmalloc(ORIGIN_HASH_SIZE * sizeof(struct list_head),
- GFP_KERNEL);
+ _origins = kmalloc_array(ORIGIN_HASH_SIZE,
+ sizeof(*_origins),
+ GFP_KERNEL);
if (!_origins) {
DMERR("unable to allocate memory for _origins");
return -ENOMEM;
@@ -335,8 +336,9 @@ static int init_origin_hash(void)
for (i = 0; i < ORIGIN_HASH_SIZE; i++)
INIT_LIST_HEAD(_origins + i);
- _dm_origins = kmalloc(ORIGIN_HASH_SIZE * sizeof(struct list_head),
- GFP_KERNEL);
+ _dm_origins = kmalloc_array(ORIGIN_HASH_SIZE,
+ sizeof(*_dm_origins),
+ GFP_KERNEL);
if (!_dm_origins) {
DMERR("unable to allocate memory for _dm_origins");
kfree(_origins);
--
2.10.0
next prev parent reply other threads:[~2016-09-29 9:07 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <566ABCD9.1060404@users.sourceforge.net>
2016-09-28 15:34 ` [PATCH 00/10] md/dm-crypt: Fine-tuning for five function implementations SF Markus Elfring
2016-09-28 15:36 ` [PATCH 01/10] md/dm-crypt: Use kcalloc() in crypt_alloc_tfms() SF Markus Elfring
2016-09-28 15:38 ` [PATCH 00/10] md/dm-crypt: Fine-tuning for five function implementations Mike Snitzer
2016-09-28 15:38 ` [PATCH 02/10] md/dm-crypt: Reduce the scope for a variable in crypt_alloc_tfms() SF Markus Elfring
2016-09-28 15:40 ` [PATCH 03/10] md/dm-crypt: Rename a jump label in crypt_message() SF Markus Elfring
2016-09-29 12:55 ` [dm-devel] " Theodore Ts'o
2016-09-29 15:43 ` SF Markus Elfring
2016-09-30 10:06 ` Dan Carpenter
2016-09-30 11:32 ` md/dm-crypt: Rename a jump label in crypt_message() ? SF Markus Elfring
2016-09-30 11:39 ` Bjørn Mork
2016-09-30 11:53 ` SF Markus Elfring
2016-09-30 12:06 ` Bjørn Mork
2016-09-30 12:54 ` SF Markus Elfring
2016-09-30 12:02 ` Dan Carpenter
2016-09-30 12:19 ` SF Markus Elfring
2016-09-28 15:41 ` [PATCH 04/10] md/dm-crypt: Delete an unnecessary variable initialisation in crypt_message() SF Markus Elfring
2016-09-28 15:42 ` [PATCH 05/10] md/dm-crypt: Rename a jump label in crypt_set_key() SF Markus Elfring
2016-09-29 12:56 ` [dm-devel] " Theodore Ts'o
2016-09-28 15:43 ` [PATCH 06/10] md/dm-crypt: Delete an unnecessary variable initialisation " SF Markus Elfring
2016-09-28 15:44 ` [PATCH 07/10] md/dm-crypt: Rename a jump label in crypt_iv_tcw_whitening() SF Markus Elfring
2016-09-28 15:45 ` [PATCH 08/10] md/dm-crypt: Return directly after a failed crypto_alloc_ahash() in crypt_iv_essiv_ctr() SF Markus Elfring
2016-09-28 15:46 ` [PATCH 09/10] md/dm-crypt: Two checks and one function call less in crypt_iv_essiv_ctr() after error detection SF Markus Elfring
2016-09-28 15:47 ` [PATCH 10/10] md/dm-crypt: Delete unnecessary variable initialisations in crypt_iv_essiv_ctr() SF Markus Elfring
2016-09-29 9:02 ` [PATCH 00/10] dm snapshot: Fine-tuning for several function implementations SF Markus Elfring
2016-09-29 9:07 ` SF Markus Elfring [this message]
2016-09-29 9:54 ` [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() Paul Bolle
2016-09-29 10:02 ` Joe Perches
2016-09-29 11:12 ` Paul Bolle
2016-09-29 11:45 ` Paul Bolle
2016-09-29 15:01 ` Joe Perches
2016-09-29 19:43 ` Paul Bolle
2016-09-29 20:24 ` Joe Perches
2016-09-29 20:39 ` Paul Bolle
2016-09-29 20:56 ` Joe Perches
2016-09-29 21:14 ` Paul Bolle
2016-09-29 21:21 ` Joe Perches
2016-09-29 21:42 ` Paul Bolle
2016-09-30 7:14 ` dm snapshot: Use kmalloc_array() in init_origin_hash() ? SF Markus Elfring
2016-09-29 11:45 ` dm snapshot: Use kmalloc_array() in init_origin_hash() SF Markus Elfring
2016-09-29 12:59 ` Theodore Ts'o
2016-09-29 9:10 ` [PATCH 02/10] dm snapshot: Delete two error messages for a failed memory allocation SF Markus Elfring
2016-09-29 9:11 ` [PATCH 03/10] dm snapshot: Delete an unnecessary variable initialisation in snapshot_map() SF Markus Elfring
2016-09-29 9:12 ` [PATCH 04/10] dm snapshot: Rename a jump label in pending_complete() SF Markus Elfring
2016-09-29 9:13 ` [PATCH 05/10] dm snapshot: Delete unnecessary variable initialisations " SF Markus Elfring
2016-09-29 9:14 ` [PATCH 06/10] dm snapshot: Delete an unnecessary variable initialisation in snapshot_ctr() SF Markus Elfring
2016-09-29 9:15 ` [PATCH 07/10] dm snapshot: Delete an unnecessary variable initialisation in merge_callback() SF Markus Elfring
2016-09-29 9:16 ` [PATCH 08/10] dm snapshot: Delete an unnecessary variable initialisation in remove_single_exception_chunk() SF Markus Elfring
2016-09-29 9:17 ` [PATCH 09/10] dm snapshot: Combine substrings for seven error messages SF Markus Elfring
2016-09-29 9:18 ` [PATCH 10/10] dm snapshot: Delete five unwanted spaces behind "list_for_each_entry" SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3861d349-48fd-162b-a749-83e007f70b41@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).