From: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
To: Alasdair Kergon <agk@redhat.com>
Cc: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>,
Mike Snitzer <snitzer@redhat.com>,
Heinz Mauelshagen <mauelshagen@redhat.com>,
dm-devel@redhat.com, Mikulas Patocka <mpatocka@redhat.com>,
Zdenek Kabelac <zkabelac@redhat.com>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
Milan Broz <mbroz@redhat.com>
Subject: Re: dm: bind new table before destroying old
Date: Thu, 12 Nov 2009 18:59:20 +0900 [thread overview]
Message-ID: <4AFBDC78.5040801@ct.jp.nec.com> (raw)
In-Reply-To: <20091111151110.GO17055@agk-dp.fab.redhat.com>
Hi Alasdair,
On 11/12/2009 12:11 AM +0900, Alasdair G Kergon wrote:
> On Wed, Nov 11, 2009 at 03:56:05PM +0900, Kiyoshi Ueda wrote:
>> I believe dm-mpath needs to flush such workqueues in postsuspend.
>
> Yes - should be an easy change.
OK, I posted the patch.
See: http://patchwork.kernel.org/patch/59556/
>> Also, we need something to block message ioctl to suspended device.
>
>> As for the message ioctl, I don't have any good idea, but...
>> - Reject message ioctl to suspended device in dm-ioctl
>
> I think the crypt target expects to be able to do this to manipulate
> the in-core encryption key.
>
>> - Targets must not kick any work influencing external themselves
>> in their message ioctl handlers.
>
> So I think we'll need a target-specific approach like that here.
OK, Mike Anderson seems to be working on this.
Thanks,
Kiyoshi Ueda
next prev parent reply other threads:[~2009-11-12 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 1:16 dm: bind new table before destroying old Alasdair G Kergon
2009-11-11 1:20 ` Alasdair G Kergon
2009-11-11 2:48 ` dm: keep old table until after resume succeeded Alasdair G Kergon
2009-11-11 6:56 ` dm: bind new table before destroying old Kiyoshi Ueda
2009-11-11 15:11 ` Alasdair G Kergon
2009-11-11 15:14 ` Milan Broz
2009-11-12 7:00 ` Mike Anderson
2009-11-12 9:59 ` Kiyoshi Ueda [this message]
2009-11-11 13:20 ` Mike Snitzer
2009-11-11 23:45 ` Mike Snitzer
2009-11-19 0:50 ` Alasdair G Kergon
2009-11-19 2:51 ` malahal
2009-11-19 12:49 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFBDC78.5040801@ct.jp.nec.com \
--to=k-ueda@ct.jp.nec.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=mauelshagen@redhat.com \
--cc=mbroz@redhat.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox