From mboxrd@z Thu Jan 1 00:00:00 1970 From: Milan Broz Subject: Re: Re: dm: sysfs add empty release function to avoid debug warning Date: Wed, 16 Dec 2009 19:40:27 +0100 Message-ID: <4B29299B.5080704@redhat.com> References: <200912151735.nBFHZ8XP018683@hera.kernel.org> <20091216004739.GB4898@kroah.com> <4B28AC09.2000302@redhat.com> <20091216134538.GA20857@kroah.com> <4B290B95.10306@redhat.com> <20091216174632.GA12473@kroah.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091216174632.GA12473@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Greg KH Cc: device-mapper development , linux-kernel@vger.kernel.org, Alasdair G Kergon , Zdenek Kabelac List-Id: dm-devel.ids On 12/16/2009 06:46 PM, Greg KH wrote: > You will find that all of these are modules, right? That's being worked > on still. probably. I see that this implementation is in kernel since import to git... What's the right solution in this particular case? It is exactly the same situation (using embedded kobj like module handle does). In DM, the whole problem here is that kobject is used for attribute representation of mapped device, mapped device struct is using its own reference counting and can dissappear before the kobject. So it must properly solve this situation. > Again, please fix your code not to have an empty release function. Will > you revert this change and fix it properly? Sure, working on it. Proper fix will replace this when ready. Milan