dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: Richard Kralovic <Richard.Kralovic@dcs.fmph.uniba.sk>
Cc: linux-kernel@vger.kernel.org,
	device-mapper development <dm-devel@redhat.com>
Subject: Re: CFQ and dm-crypt
Date: Sun, 24 Oct 2010 18:15:41 +0200	[thread overview]
Message-ID: <4CC45BAD.2060308@redhat.com> (raw)
In-Reply-To: <4CC439ED.8090400@dcs.fmph.uniba.sk>

On 10/24/2010 03:51 PM, Richard Kralovic wrote:
> CFQ io scheduler relies on using task_struct current to determine which
> process makes the io request. On the other hand, some dm modules (such
> as dm-crypt) use separate threads for doing io. As CFQ sees only these
> threads, it provides a very poor performance in such a case.
> 
> IMHO the correct solution for this would be to store, for every io
> request, the process that initiated it (and preserve this information
> while the request is processed by device mapper). Would that be feasible?

Yes, this seems to be correct solution. I think this should be
handled by core device-mapper (as you noted, more dm targets using
threads to process.)


> Other possibility is to avoid using separate threads for doing io in dm
> modules. The attached patch (against 2.6.36) modifies dm-crypt in this
> way, what results into much better behavior of cfq (e.g., io priorities
> work correctly).

Sorry, this completely dismantles the way how dm-crypt solves problems
with stacking dm devices.
Basically it reintroduces possible deadlocks for low memory
situations (the reason why there are these threads).

Milan

       reply	other threads:[~2010-10-24 16:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4CC439ED.8090400@dcs.fmph.uniba.sk>
2010-10-24 16:15 ` Milan Broz [this message]
2010-10-25  9:53   ` CFQ and dm-crypt Richard Kralovic
2010-10-25 11:09     ` Milan Broz
2010-10-25 14:22       ` Jeff Moyer
2010-10-25 20:59     ` Vivek Goyal
2010-10-26  8:37       ` Richard Kralovic
2010-10-26 10:57         ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC45BAD.2060308@redhat.com \
    --to=mbroz@redhat.com \
    --cc=Richard.Kralovic@dcs.fmph.uniba.sk \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).