dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Mike Christie <mchristi@redhat.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Nikanth Karthikesan <knikanth@suse.de>,
	device-mapper development <dm-devel@redhat.com>,
	sekharan@linux.vnet.ibm.com
Subject: Re: dm mpath: delay retry activate_path on SCSI_DH_RETRY
Date: Tue, 02 Nov 2010 16:02:53 -0500	[thread overview]
Message-ID: <4CD07C7D.2090509@redhat.com> (raw)
In-Reply-To: <20101102193217.GA23680@redhat.com>

On 11/02/2010 02:32 PM, Mike Snitzer wrote:
> On Tue, Jun 09 2009 at  4:54pm -0400,
> Chandra Seetharaman<sekharan@us.ibm.com>  wrote:
>
>> No functional change.
>>
>> Repost with changes made to apply cleanly on top of the patch
>> (http://marc.info/?l=dm-devel&m=124424663327710&w=2) that changed
>> dm-mpath.c
>>
>> -----------------
>> From: Chandra Seetharaman<sekharan@us.ibm.com>
>>
>> SCSI Device Handlers return SCSI_DH_IMM_RETRY if we could retry
>> immediately and SCSI_DH_RETRY in cases where it is better to retry
>> after some delay.
>>
>> Currently we retry immediately irrespective of SCSI_DH_IMM_RETRY and
>> SCSI_DH_RETRY. This patch adds a user configurable attribute
>> pg_init_delay_secs which specifies the number of seconds to delay
>> before retrying scsi_dh_activate, when it returned SCSI_DH_RETRY.
>>
>> Default for this attribute is set to 2 seconds.
>>
>> Signed-off-by: Nikanth Karthikesan<knikanth@suse.de>
>> Signed-off-by: Chandra Seetharaman<sekharan@us.ibm.com>
>
> I'm auditing dm-devel's patchwork and would just like to confirm that
> others would still like to see this go in?
>
> Patch in question is captured here:
> https://patchwork.kernel.org/patch/29088/
>
> Mike C.,
> An earlier version of this patch got your "Looks ok.":
> https://patchwork.kernel.org/patch/23946/
> Can I translate that to your "Acked-by:" if/when I rebase and repost?
>

Yeah.

      parent reply	other threads:[~2010-11-02 21:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05  3:18 [PATCH] dm mpath: delay retry activate_path on SCSI_DH_RETRY Chandra Seetharaman
2009-05-15  3:10 ` Chandra Seetharaman
2009-05-15 13:38   ` Mike Christie
2009-06-09 20:54   ` Chandra Seetharaman
2010-11-02 19:32     ` Mike Snitzer
2010-11-02 19:56       ` Chandra Seetharaman
2010-11-02 21:02       ` Mike Christie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CD07C7D.2090509@redhat.com \
    --to=mchristi@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=knikanth@suse.de \
    --cc=sekharan@linux.vnet.ibm.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).