From: Jens Axboe <jaxboe@fusionio.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
Alasdair G Kergon <agk@redhat.com>,
Li Zefan <lizf@cn.fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] block: rename trace_block_remap to trace_block_bio_remap
Date: Tue, 16 Nov 2010 12:51:48 +0100 [thread overview]
Message-ID: <4CE27054.3000309@fusionio.com> (raw)
In-Reply-To: <20101115213444.GA25705@redhat.com>
On 2010-11-15 22:34, Mike Snitzer wrote:
> On Mon, Nov 15 2010 at 3:58pm -0500,
> Mike Snitzer <snitzer@redhat.com> wrote:
>
>> Hi Jens,
>>
>> This may have slipped through while you were traveling?
>>
>> Patch is also available here:
>> https://patchwork.kernel.org/patch/300552/
>>
>> Not sure if this change is concerning on a kABI level?
>
> To be clear: that concern/question was prompted from having taken a
> quick glance at lwn's kernel summit "KS2010: ABI status for tracepoints"
> coverage: http://lwn.net/Articles/412685/
>
> But in that article it clearly states:
> "there are to be no stable tracepoints in drivers or filesystems".
>
> Not sure where that leaves tracepoints for the block layer. Anyway,
> seems tracepoint kABI is likely a concern for the future (not the
> immediate future).
>
> So this change would be nice to get in before there is a new tracepoint
> kABI-aware sheriff in town.
As far as I'm concerned, trace point changes in the block area cannot
break existing blktrace (as in cause malfunction). So this patch is
fine, I'll pick it up for .38.
--
Jens Axboe
prev parent reply other threads:[~2010-11-16 11:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 15:13 [PATCH 2/3] block: Rename trace_block_remap to trace_block_bio_remap Jun'ichi Nomura
2009-09-18 16:13 ` Daniel Walker
2009-09-19 15:30 ` Jun'ichi Nomura
2010-11-03 21:50 ` [PATCH v2] block: rename " Mike Snitzer
2010-11-15 20:58 ` Mike Snitzer
2010-11-15 21:34 ` Mike Snitzer
2010-11-16 11:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE27054.3000309@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).