Linux Device Mapper development
 help / color / mirror / Atom feed
From: "Bryn M. Reeves" <bmr@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: dm-cvs@sourceware.org, bmarzins@sourceware.org
Subject: Re: multipath-tools multipath.conf.synthetic
Date: Tue, 08 Mar 2011 09:57:20 +0000	[thread overview]
Message-ID: <4D75FD80.2030600@redhat.com> (raw)
In-Reply-To: <20110307184204.25414.qmail@sourceware.org>

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

On 03/07/2011 06:42 PM, bmarzins@sourceware.org wrote:
> CVSROOT:	/cvs/dm
> Module name:	multipath-tools
> Branch: 	RHEL5_FC6
> Changes by:	bmarzins@sourceware.org	2011-03-07 18:42:03
> 
> Modified files:
> 	.              : multipath.conf.synthetic 
> 
> Log message:
> 	Forgot to remove /bin/true reference from multipath.conf.synthetic. Removing.
> 	Not applicable upstream.
> 
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/multipath-tools/multipath.conf.synthetic.diff?cvsroot=dm&only_with_tag=RHEL5_FC6&r1=1.11.2.6&r2=1.11.2.7
> 
> --- multipath-tools/multipath.conf.synthetic	2008/09/08 22:01:19	1.11.2.6
> +++ multipath-tools/multipath.conf.synthetic	2011/03/07 18:42:03	1.11.2.7
> @@ -8,7 +8,7 @@
>  #	selector		"round-robin 0"
>  #	path_grouping_policy	multibus
>  #	getuid_callout		"/sbin/scsi_id -g -u -s /block/%n"
> -#	prio_callout		/bin/true
> +#	prio_callout		none
>  #	path_checker		readsector0
>  #	rr_min_io		100
>  #	max_fds			8192

Thanks Ben, I think we should also remove the reference from
multipath/multipath.conf.redhat as this is the default /etc/multipath.conf on
Red Hat systems and users blindly un-commenting the example may create problems
(e.g. boot from SAN fails) - patch attached.

#defaults {
#	udev_dir		/dev
#	polling_interval 	10
#	selector		"round-robin 0"
#	path_grouping_policy	multibus
#	getuid_callout		"/sbin/scsi_id -g -u -s /block/%n"
#	prio_callout		/bin/true
#	path_checker		readsector0
#	rr_min_io		100
#	max_fds			8192
#	rr_weight		priorities
#	failback		immediate
#	no_path_retry		fail
#	user_friendly_names	yes
#}

Regards,
Bryn.

[-- Attachment #2: multipath-tools-drop-bin-true-prio-callout.patch --]
[-- Type: text/plain, Size: 557 bytes --]

diff -up multipath-tools/multipath/multipath.conf.redhat.orig multipath-tools/multipath/multipath.conf.redhat
--- multipath-tools/multipath/multipath.conf.redhat.orig	2011-03-08 09:55:59.000000000 +0000
+++ multipath-tools/multipath/multipath.conf.redhat	2011-03-08 09:56:06.000000000 +0000
@@ -25,7 +25,7 @@ defaults {
 #	selector		"round-robin 0"
 #	path_grouping_policy	multibus
 #	getuid_callout		"/sbin/scsi_id -g -u -s /block/%n"
-#	prio_callout		/bin/true
+#	prio_callout		none
 #	path_checker		readsector0
 #	rr_min_io		100
 #	rr_weight		priorities

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



      reply	other threads:[~2011-03-08  9:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07 18:42 multipath-tools multipath.conf.synthetic bmarzins
2011-03-08  9:57 ` Bryn M. Reeves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D75FD80.2030600@redhat.com \
    --to=bmr@redhat.com \
    --cc=bmarzins@sourceware.org \
    --cc=dm-cvs@sourceware.org \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox