From: Mike Christie <michaelc@cs.wisc.edu>
To: device-mapper development <dm-devel@redhat.com>
Cc: "Moger, Babu" <Babu.Moger@lsi.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Krishnasamy, Somasundaram" <Somasundaram.Krishnasamy@lsi.com>,
"Stankey, Robert" <Robert.Stankey@lsi.com>
Subject: Re: [dm-devel] [PATCH 1/3] scsi_dh_rdac : Add definitions for different RDAC operating modes
Date: Thu, 21 Apr 2011 13:10:46 -0500 [thread overview]
Message-ID: <4DB07326.4010503@cs.wisc.edu> (raw)
In-Reply-To: <E463DF2B2E584B4A82673F53D62C2EF4FFAC9624@cosmail01.lsi.com>
Patches 1 - 3 look ok to me.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
On 04/08/2011 12:37 PM, Moger, Babu wrote:
> This patch adds definitions to support for different operating modes for LSI rdac storage.
> Currently, rdac support 3 operation modes.
>
> 1. RDAC mode(legacy)
> 2. AVT mode
> 3. IOSHIP mode
> These definitions are used while activating the path(rdac_activate).
>
> Signed-off-by: Babu Moger<babu.moger@lsi.com>
> Reviewed-by: Yanling Qi<yanling.qi@lsi.com>
> Reviewed-by: Sudhir Dachepalli<Sudhir.Dachepalli@lis.com>
> Reviewed-by: Somasundaram Krishnasamy<Somasundaram.Krishnasamy@lsi.com>
> Reviewed-by: Bob Stankey<Robert.Stankey@lsi.com>
> Reviewed-by: Vijay Chauhan<Vijay.Chauhan@lsi.com>
>
> ---
> --- linux-2.6.38/drivers/scsi/device_handler/scsi_dh_rdac.c.orig 2011-03-17 16:31:53.000000000 -0500
> +++ linux-2.6.38/drivers/scsi/device_handler/scsi_dh_rdac.c 2011-03-17 16:47:52.000000000 -0500
> @@ -182,6 +182,12 @@ struct rdac_dh_data {
> struct rdac_controller *ctlr;
> #define UNINITIALIZED_LUN (1<< 8)
> unsigned lun;
> +
> +#define RDAC_MODE 0
> +#define RDAC_MODE_AVT 1
> +#define RDAC_MODE_IOSHIP 2
> + unsigned char mode;
> +
> #define RDAC_STATE_ACTIVE 0
> #define RDAC_STATE_PASSIVE 1
> unsigned char state;
> @@ -190,6 +196,11 @@ struct rdac_dh_data {
> #define RDAC_LUN_OWNED 1
> #define RDAC_LUN_AVT 2
> char lun_state;
> +
> +#define RDAC_PREFERRED 0
> +#define RDAC_NON_PREFERRED 1
> + char preferred;
> +
> unsigned char sense[SCSI_SENSE_BUFFERSIZE];
> union {
> struct c2_inquiry c2;
> @@ -199,11 +210,15 @@ struct rdac_dh_data {
> } inq;
> };
>
> +static const char *mode[] = {
> + "RDAC",
> + "AVT",
> + "IOSHIP",
> +};
> static const char *lun_state[] =
> {
> "unowned",
> "owned",
> - "owned (AVT mode)",
> };
>
> struct rdac_queue_data {
> @@ -836,8 +851,9 @@ static int rdac_bus_attach(struct scsi_d
> spin_unlock_irqrestore(sdev->request_queue->queue_lock, flags);
>
> sdev_printk(KERN_NOTICE, sdev,
> - "%s: LUN %d (%s)\n",
> - RDAC_NAME, h->lun, lun_state[(int)h->lun_state]);
> + "%s: LUN %d (%s) (%s)\n",
> + RDAC_NAME, h->lun, mode[(int)h->mode],
> + lun_state[(int)h->lun_state]);
>
> return 0;
>
>
>
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2011-04-21 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 17:37 [PATCH 1/3] scsi_dh_rdac : Add definitions for different RDAC operating modes Moger, Babu
2011-04-20 15:08 ` Moger, Babu
2011-04-21 18:10 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB07326.4010503@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=Babu.Moger@lsi.com \
--cc=Robert.Stankey@lsi.com \
--cc=Somasundaram.Krishnasamy@lsi.com \
--cc=dm-devel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox