Linux Device Mapper development
 help / color / mirror / Atom feed
From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	jaxboe@fusionio.com, jbottomley@parallels.com,
	roland@purestorage.com,
	device-mapper development <dm-devel@redhat.com>,
	tj@kernel.org, "Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: [PATCH v2] dm mpath: maintain reference count for underlying devices
Date: Tue, 18 Oct 2011 22:00:48 +0900	[thread overview]
Message-ID: <4E9D7880.60201@ce.jp.nec.com> (raw)
In-Reply-To: <20111017201514.GA21731@redhat.com>

On 10/18/11 05:15, Mike Snitzer wrote:
> FYI, this patch from Tejun should also fix the concern I had relative to
> mpath's underlying devices' request_queues:
> https://lkml.org/lkml/2011/10/16/148

Oh, that's good information.

Since the following commit, a queue can be accessed
after the device being released:

  commit f758eeabeb96f878c860e8f110f94ec8820822a9
  Author: Christoph Hellwig <hch@infradead.org>
  Date:   Thu Apr 21 18:19:44 2011 -0600

    writeback: split inode_wb_list_lock into bdi_writeback.list_lock

I.e.
  __blkdev_put
    disk->fops->release()
    ..
    bdev_inode_switch_bdi()
      bdi_lock_two()
      [access to bdev->bd_inode->i_data.backing_dev_info]

I think Tejun's patch is reasonable.

Thanks,
-- 
Jun'ichi Nomura, NEC Corporation

      reply	other threads:[~2011-10-18 13:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-16 13:59 [PATCH v2] dm mpath: maintain reference count for underlying devices Mike Snitzer
2011-09-19  6:49 ` Jun'ichi Nomura
2011-09-19 14:34   ` Mike Snitzer
2011-09-20  5:29     ` Jun'ichi Nomura
2011-09-20  7:13       ` James Bottomley
2011-09-20 11:31         ` Jun'ichi Nomura
2011-10-17 20:15       ` Mike Snitzer
2011-10-18 13:00         ` Jun'ichi Nomura [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9D7880.60201@ce.jp.nec.com \
    --to=j-nomura@ce.jp.nec.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=jaxboe@fusionio.com \
    --cc=jbottomley@parallels.com \
    --cc=martin.petersen@oracle.com \
    --cc=roland@purestorage.com \
    --cc=snitzer@redhat.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox