dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: device-mapper development <dm-devel@redhat.com>,
	Ben Hutchings <ben@decadent.org.uk>,
	648367@bugs.debian.org
Subject: Bug#648367: [dm-devel] Bug#648367: device-mapper devices such as dm-crypt always have rotational=1; should inherit "rotational" setting from underlying devices
Date: Tue, 15 Nov 2011 18:05:31 +0100	[thread overview]
Message-ID: <4EC29BDB.8090803@redhat.com> (raw)
In-Reply-To: <20111115164151.GA24015@leaf>

On 11/15/2011 05:41 PM, Josh Triplett wrote:
> I didn't know about that command; very nice, thanks!  lsblk confirms
> that on my system, the physical disk has rotational=0 but the dm-crypt
> and LVM devices have rotational=1:
> 
> NAME                   ALIGNMENT MIN-IO OPT-IO PHY-SEC LOG-SEC ROTA SCHED
> sda                            0    512      0     512     512    0 cfq
> ├─sda1                         0    512      0     512     512    0 cfq
> └─sda2                         0    512      0     512     512    0 cfq
>   └─sda2_crypt (dm-0)          0    512      0     512     512    1 
>     ├─leaf-swap (dm-1)         0    512      0     512     512    1 
>     └─leaf-root (dm-2)         0    512      0     512     512    1 
> 
> Does that help?

Thanks.

As noted on that bug earlier, it is already fixed in 3.2-rc1
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=4693c9668fdcec229825b3763876b4744f9e6d5e

(I thought it is fixed long time ago!)

There is no problem in DM layer with this (dmcrypt does not have own io scheduler)
but perhaps FS can use this flag for some optimization tuning, dunno.

Milan

      reply	other threads:[~2011-11-15 17:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20111110195943.12083.93273.reportbug@leaf>
2011-11-14  1:05 ` Bug#648367: device-mapper devices such as dm-crypt always have rotational=1; should inherit "rotational" setting from underlying devices Ben Hutchings
2011-11-14  2:26   ` Josh Triplett
2011-11-15  7:34     ` Milan Broz
2011-11-15 16:41       ` Bug#648367: [dm-devel] " Josh Triplett
2011-11-15 17:05         ` Milan Broz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC29BDB.8090803@redhat.com \
    --to=mbroz@redhat.com \
    --cc=648367@bugs.debian.org \
    --cc=ben@decadent.org.uk \
    --cc=dm-devel@redhat.com \
    --cc=josh@joshtriplett.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).