From: Jens Axboe <axboe@kernel.dk>
To: Mike Snitzer <snitzer@redhat.com>
Cc: linux-kernel@vger.kernel.org, dm-devel@redhat.com,
vijay.chauhan@netapp.com
Subject: Re: [RESEND PATCH] block: do not artificially constrain max_sectors for stacking drivers
Date: Wed, 01 Aug 2012 10:45:08 +0200 [thread overview]
Message-ID: <5018EC94.1050405@kernel.dk> (raw)
In-Reply-To: <1343781553-17089-1-git-send-email-snitzer@redhat.com>
On 08/01/2012 02:39 AM, Mike Snitzer wrote:
> blk_set_stacking_limits is intended to allow stacking drivers to build
> up the limits of the stacked device based on the underlying devices'
> limits. But defaulting 'max_sectors' to BLK_DEF_MAX_SECTORS (1024)
> doesn't allow the stacking driver to inherit a max_sectors larger than
> 1024 -- due to blk_stack_limits' use of min_not_zero.
>
> It is now clear that this artificial limit is getting in the way so
> change blk_set_stacking_limits's max_sectors to UINT_MAX (which allows
> stacking drivers like dm-multipath to inherit 'max_sectors' from the
> underlying paths).
Thanks Mike (and Vijay), applied for 3.6.
--
Jens Axboe
prev parent reply other threads:[~2012-08-01 8:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 17:59 [PATCH] DM MULTIPATH: Allow dm to send larger request if underlying device set to larger max_sectors value Chauhan, Vijay
2012-07-09 1:01 ` Alasdair G Kergon
2012-07-09 12:34 ` Chauhan, Vijay
2012-07-09 13:00 ` Mike Snitzer
2012-07-09 13:16 ` Mike Snitzer
2012-07-09 13:40 ` Mike Snitzer
2012-07-09 14:14 ` [PATCH] block: do not artificially constrain max_sectors for stacking drivers Mike Snitzer
2012-07-09 14:57 ` [PATCH v2] " Mike Snitzer
2012-07-09 22:57 ` Mike Snitzer
2012-07-10 19:10 ` Chauhan, Vijay
2012-07-10 19:18 ` Mike Snitzer
2012-08-01 0:39 ` [RESEND PATCH] " Mike Snitzer
2012-08-01 8:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5018EC94.1050405@kernel.dk \
--to=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=vijay.chauhan@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).