From: Bart Van Assche <bvanassche@acm.org>
To: dm-devel@redhat.com
Cc: Jens Axboe <axboe@kernel.dk>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
Tejun Heo <tj@kernel.org>, Alasdair G Kergon <agk@redhat.com>
Subject: [PATCH] dm: Update a source code comment
Date: Mon, 03 Dec 2012 13:32:32 +0100 [thread overview]
Message-ID: <50BC9BE0.30108@acm.org> (raw)
Update a source code comment with the conclusions of the discussion
of the patch that introduced this comment (commit a8c32a5). See also
http://www.redhat.com/archives/dm-devel/2012-November/msg00003.html.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Alasdair G Kergon <agk@redhat.com>
Cc: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org
---
drivers/md/dm.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 77e6eff..0ec0673 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -740,12 +740,7 @@ static void rq_completed(struct mapped_device *md, int rw, int run_queue)
if (!md_in_flight(md))
wake_up(&md->wait);
- /*
- * Run this off this callpath, as drivers could invoke end_io while
- * inside their request_fn (and holding the queue lock). Calling
- * back into ->request_fn() could deadlock attempting to grab the
- * queue lock again.
- */
+ /* run queue asynchronously to minimize time spent in soft-IRQ ctxt */
if (run_queue)
blk_run_queue_async(md->queue);
--
1.7.10.4
reply other threads:[~2012-12-03 12:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BC9BE0.30108@acm.org \
--to=bvanassche@acm.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox