From: Hannes Reinecke <hare@suse.de>
To: dm-devel@redhat.com
Subject: Re: [PATCH v2] multipath: make devt2devname use lstat to check sysfs links
Date: Fri, 11 Jan 2013 08:01:17 +0100 [thread overview]
Message-ID: <50EFB8BD.7000501@suse.de> (raw)
In-Reply-To: <20130110200619.GP19059@ether.msp.redhat.com>
On 01/10/2013 09:06 PM, Benjamin Marzinski wrote:
> dm_reassign wasn't working correctly for me because devt2devname used stat()
> to check if /sys/dev/block/major:minor was a symlink. But stat() never returns
> a symlink, if follows it. It needs to use lstat() instead. Also, I made
> multipath log a message when a dm device gets reassigned to use multipath.
>
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Acked-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
prev parent reply other threads:[~2013-01-11 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 20:06 [PATCH v2] multipath: make devt2devname use lstat to check sysfs links Benjamin Marzinski
2013-01-11 7:01 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EFB8BD.7000501@suse.de \
--to=hare@suse.de \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox