Linux Device Mapper development
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: christophe.varoqui@opensvc.com
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>,
	Christophe Varoqui <christophe.varoqui@gmail.com>
Subject: Re: [PATCH 1/2] [multipath-tools] Fix failback parameter parsing in conf
Date: Mon, 29 Apr 2013 08:01:30 +0200	[thread overview]
Message-ID: <517E0CBA.3060309@suse.de> (raw)
In-Reply-To: <1367050707.23503.6.camel@lapoo.opensvc.com>

On 04/27/2013 10:18 AM, Christophe Varoqui wrote:
> On mar., 2013-04-23 at 21:21 +0000, Stewart, Sean wrote:
>> This patch fixes a problem introduced in this commit: http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=commitdiff;h=cef43b6f910f740c0e2d38761f58c5ebedfb7585;hp=41b85341ca514a50d18c592996a2ecb43a81fa90
>> Currently, the string handler for failback on hw entries expects strings like "manual" to be quoted.  The buffer always strips quotes.
>> As a result, the keywords manual, immediate, and followover cannot be used to change a failback parameter through multipath.conf
>>
> Hannes,
> 
> do you ack this one, which reverts part of
> cef43b6f910f740c0e2d38761f58c5ebedfb7585 from your tree ?
> 
Yes, sorry. Was an oversight on my part.

Acked-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

  reply	other threads:[~2013-04-29  6:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23 21:21 [PATCH 1/2] [multipath-tools] Fix failback parameter parsing in conf Stewart, Sean
2013-04-27  8:18 ` Christophe Varoqui
2013-04-29  6:01   ` Hannes Reinecke [this message]
2013-04-29 20:51 ` Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517E0CBA.3060309@suse.de \
    --to=hare@suse.de \
    --cc=christophe.varoqui@gmail.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox