[Question] How to make a patch?

[Question] How to make a patch?

[Akira Hayakawa]

Hi,

I am going to send you a patch of dm-lc on this weekend.
But, I am wondering how I make a patch.

1. What tree do I need to use?
2. Where should I make a patch on?

I git-cloned both linux-next and linux-dm.
Which one should I use?

linux-dm seems to have a tag dm-3.11-changes.
Should I make patch on this point?

Sorry for too basic question,
Akira

Re: [Question] How to make a patch?

[Alasdair G Kergon]

On Sat, Aug 10, 2013 at 08:12:02AM +0900, Akira Hayakawa wrote:
> linux-dm seems to have a tag dm-3.11-changes.
> Should I make patch on this point?
 
At this stage, create a patch based against a released -rc kernel 
from Linus.

If you use the linux-dm tree, then you can pick the tag v3.11-rc3,
for example, which is the last time we updated.

Alasdair

Re: [Question] How to make a patch?

[Akira Hayakawa]

On 8/10/13 8:22 AM, Alasdair G Kergon wrote:
> At this stage, create a patch based against a released -rc kernel 
> from Linus.
> 
> If you use the linux-dm tree, then you can pick the tag v3.11-rc3,
> for example, which is the last time we updated.

Thanks for your response.

And I have a further question.

Do you mean
making a patch against rc4 in linux-next is not preferred?
I think if doing so,
the patch will be unable to apply to linux-dm
which I believe one going to be suggested to Linus.

I think I am going to make my patch against
v3.11-rc3 in linux-dm.
But, patching on kernel as fresh as possible
would make sense more.

Re: [Question] How to make a patch?

[Alasdair G Kergon]

On Sat, Aug 10, 2013 at 08:47:11AM +0900, Akira Hayakawa wrote:
> Do you mean
> making a patch against rc4 in linux-next is not preferred?

The risk of patching against linux-next directly is that you might find
yourself debugging problems in other subsystems when you try to test:)
But others would say that is that an advantage:)

It really shouldn't matter which point you choose at the moment because 
very little (nothing?) of relevance to your patch should be changing and
there will still be more revisions before the code is ready.

(For example, I think I saw someone point out that the interface needs a
careful review and might work better if done a different way.)

Alasdair

Re: [Question] How to make a patch?

[Akira Hayakawa]

On 8/10/13 9:07 AM, Alasdair G Kergon wrote:
> It really shouldn't matter which point you choose at the moment because 
> very little (nothing?) of relevance to your patch should be changing and
> there will still be more revisions before the code is ready.

Thanks, I understand.

I will write code on linux-dm and
make my patch on v3.11-rc3.

Akira