dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Akira Hayakawa <ruby.wktk@gmail.com>
To: dm-devel@redhat.com
Cc: gregkh@linuxfoundation.org, agk@redhat.com
Subject: [RFC] dm-writeboost: Plan to add comments. Needs help to make an objective list of where to comment
Date: Mon, 16 Sep 2013 22:49:09 +0900	[thread overview]
Message-ID: <52370C55.6060906@gmail.com> (raw)

Hi,

I am thinking of adding more comments on the source code
according to the Alasdair's advice.

According to the Chapter 8 "Commenting" in Documentation/CodingStyle
WHAT it does should be commented
while HOW it works should not be but should be explained by the source code.

I was believing that only about the design issue
should be commented for the code quality.
But, on the second thought,
Linux kernel is a huge OSS 
that developers are living different timezone
and in different physical locations.
So, comments are almost all the information
that they can get beside the source code
because we can't easily chat with each other and ping pong Q&A.
That I am living in Japan might make the situation even worse.

Now that dm-writeboost is consist of 3.5k lines of code
and more 500 or 1000 lines of comments added
doesn't affect the maintainability so much.
Therefore, commenting will be paid in case of dm-writeboost.

I will be starting from commenting on WHAT it does
in the source code
including adding explanation on what the routine does
in front of the routines.

But the problem is that
I have no idea where to write comments at all.

I want to make an _objective_ list of where to comment.
Someone help me make the list?
I ask you to
read thru the code,
pick up where you couldn't understand or feel needing comments
and then report the list to me.
It will be helping a lot.

Thanks,
Akira

                 reply	other threads:[~2013-09-16 13:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52370C55.6060906@gmail.com \
    --to=ruby.wktk@gmail.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).