Linux Device Mapper development
 help / color / mirror / Atom feed
From: kusumi.tomohiro@gmail.com
To: snitzer@redhat.com, mpatocka@redhat.com
Cc: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>, dm-devel@redhat.com
Subject: [PATCH 2/2] dm flakey: document that default I/O error is only for write (resend)
Date: Wed, 13 Jan 2016 01:51:43 +0900	[thread overview]
Message-ID: <56952c88.020d620a.94f42.2f0d@mx.google.com> (raw)
In-Reply-To: <1452617503-18220-1-git-send-email-y>

From: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>

.map of dm-flakey with no optional feature parameters specified
results in -EIO only for writes during down time. Read bios are
submitted as usual whether it's in up or down time.

Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
---
 Documentation/device-mapper/dm-flakey.txt |    2 +-
 drivers/md/dm-flakey.c                    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/device-mapper/dm-flakey.txt b/Documentation/device-mapper/dm-flakey.txt
index 6ff5c23..c171706 100644
--- a/Documentation/device-mapper/dm-flakey.txt
+++ b/Documentation/device-mapper/dm-flakey.txt
@@ -27,7 +27,7 @@ Mandatory parameters:
 
 Optional feature parameters:
   If no feature parameters are present, during the periods of
-  unreliability, all I/O returns errors.
+  unreliability, all write I/O returns errors.
 
   drop_writes:
 	All write I/O is silently ignored.
diff --git a/drivers/md/dm-flakey.c b/drivers/md/dm-flakey.c
index 09e2afc..8da73ac 100644
--- a/drivers/md/dm-flakey.c
+++ b/drivers/md/dm-flakey.c
@@ -312,7 +312,7 @@ static int flakey_map(struct dm_target *ti, struct bio *bio)
 		}
 
 		/*
-		 * By default, error all I/O.
+		 * By default, error all write I/O.
 		 */
 		return -EIO;
 	}
-- 
1.7.1

           reply	other threads:[~2016-01-12 16:51 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1452617503-18220-1-git-send-email-y>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56952c88.020d620a.94f42.2f0d@mx.google.com \
    --to=kusumi.tomohiro@gmail.com \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox