From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
dm-devel@lists.linux.dev, Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH v2 1/4] block: Introduce bio_needs_zone_write_plugging()
Date: Wed, 25 Jun 2025 15:14:51 +0900 [thread overview]
Message-ID: <576bb6dd-18b1-4c78-b848-51577d99b124@kernel.org> (raw)
In-Reply-To: <aFuTYxdeAzG1iSl9@infradead.org>
On 6/25/25 3:12 PM, Christoph Hellwig wrote:
> On Wed, Jun 25, 2025 at 02:59:05PM +0900, Damien Le Moal wrote:
>> +bool bio_needs_zone_write_plugging(struct bio *bio)
>
> Can you use this in blk_zone_plug_bio instead of duplicating the logic?
I thought about doing that, but we would still need to again do the switch/case
on the bio op. But the checks before that could go into a common static helper.
> I also wonder if we should only it it, as despite looking quite complex
This does not parse...
> it should compile down to just a few instructions and is used in the
> I/O fast path.
>
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-06-25 6:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 5:59 [PATCH v2 0/4] Fix write operation handling for zoned DM devices Damien Le Moal
2025-06-25 5:59 ` [PATCH v2 1/4] block: Introduce bio_needs_zone_write_plugging() Damien Le Moal
2025-06-25 6:12 ` Christoph Hellwig
2025-06-25 6:14 ` Damien Le Moal [this message]
2025-06-25 6:18 ` Christoph Hellwig
2025-06-25 6:17 ` Damien Le Moal
2025-06-25 5:59 ` [PATCH v2 2/4] dm: Always split write BIOs to zoned device limits Damien Le Moal
2025-06-25 6:15 ` Christoph Hellwig
2025-06-25 6:15 ` Damien Le Moal
2025-06-25 5:59 ` [PATCH v2 3/4] dm: dm-crypt: Do not split write operations with zoned targets Damien Le Moal
2025-06-25 10:19 ` Mikulas Patocka
2025-06-25 12:54 ` Damien Le Moal
2025-06-25 14:03 ` Mikulas Patocka
2025-06-25 14:43 ` Damien Le Moal
2025-06-25 16:33 ` Mikulas Patocka
2025-06-25 5:59 ` [PATCH v2 4/4] dm: Check for forbidden splitting of zone write operations Damien Le Moal
2025-06-25 6:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576bb6dd-18b1-4c78-b848-51577d99b124@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@lists.linux.dev \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).