From: Hannes Reinecke <hare@suse.de>
To: Xose Vazquez Perez <xose.vazquez@gmail.com>,
device-mapper development <dm-devel@redhat.com>
Subject: Re: [BUG] multipath-tools: multipathd/main.c: cannot jump from this goto statement to its label
Date: Thu, 7 Jul 2016 07:43:47 +0200 [thread overview]
Message-ID: <577DEC13.8090503@suse.de> (raw)
In-Reply-To: <8438d5fe-5a4d-f6d5-8012-4bad9784fc25@gmail.com>
On 07/06/2016 09:54 PM, Xose Vazquez Perez wrote:
> On 06/29/2016 03:36 PM, Xose Vazquez Perez wrote:
>
>> spotted by clang-3.8.0:
>>
>> make[1]: Entering directory '/home/xose/tmp/arrays/multipath-tools.x1/multipathd'
>> clang -O2 -g -pipe -Wformat-security -Wall -fexceptions -fstack-protector --param=ssp-buffer-size=4 -Wunused -Wstrict-prototypes -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -I../libmultipath
>> -I../libmpathpersist -I../libmpathcmd -DUSE_SYSTEMD=229 -c -o main.o main.c
>> main.c:586:3: error: cannot jump from this goto statement to its label
>> goto out_unlock;
>> ^
>> main.c:631:38: note: jump bypasses initialization of variable with __attribute__((cleanup))
>> do { struct __pthread_cleanup_frame __clframe __attribute__ ((__cleanup__ (__pthread_cleanup_routine))) = { .__cancel_routine = (cleanup_lock), .__cancel_arg = (&vecs->lock), .__do_it = 1 };;
>> ^
>> 1 error generated.
>>
>
> Hannes, could you please check this error?
> The code was added in 97846ae8.
>
The mentioned commit was reverted with my pending patchset for using
user-space RCU for config accesses.
As (I think) it's about to be merged we just have to wait for Christophe
to pick up the patchset.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2016-07-07 5:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 13:36 [BUG] multipath-tools: multipathd/main.c: cannot jump from this goto statement to its label Xose Vazquez Perez
2016-06-29 14:06 ` multipath-tools: clang warnings(30) Xose Vazquez Perez
2016-07-06 19:54 ` [BUG] multipath-tools: multipathd/main.c: cannot jump from this goto statement to its label Xose Vazquez Perez
2016-07-07 5:43 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577DEC13.8090503@suse.de \
--to=hare@suse.de \
--cc=dm-devel@redhat.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).