Linux Device Mapper development
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Xose Vazquez Perez <xose.vazquez@gmail.com>,
	Mike Christie <mchristi@redhat.com>,
	device-mapper development <dm-devel@redhat.com>,
	Benjamin Marzinski <bmarzins@redhat.com>,
	Christophe Varoqui <christophe.varoqui@opensvc.com>
Subject: Re: [Question] udev ID_UID attribute ???
Date: Mon, 11 Jul 2016 08:40:50 +0200	[thread overview]
Message-ID: <57833F72.30304@suse.de> (raw)
In-Reply-To: <c6ca404f-4e0e-d7c9-de1f-60e0697df789@gmail.com>

On 07/08/2016 10:45 PM, Xose Vazquez Perez wrote:
> On 07/08/2016 05:52 PM, Mike Christie wrote:
> 
>> On 07/07/2016 04:21 PM, Xose Vazquez Perez wrote:
>>> Is "ID_UID" really valid?
>>>
>>> libmultipath/hwtable.c:         .uid_attribute = "ID_UID",
>>>
>>
>> I was wondering the same thing. For ceph rbd, we do not have the normal
>> scsi serial/wwn values, so I am modifying our udev rule to export ID_UID.
>>
>> I made the ID_UID, the values we use for the udev (/dev/rbd) name which
>> is the pool name (basically just a grouping of storage) plus the image
>> name (basically name of a disk created in a pool).
> 
> ID_UID isn't "standard". It wasn't found in kernel, multipath-tools or systemd(udev)
> sources.
> 
> It's variable returned by dasdinfo from 390-tools package, it contains the "DASD uid"
> of a dasd device. And it's used by udev rules to make symlinks for dasd devices under
> /dev/disk/by-id/
> 
> This is hercules, but in a LPAR shows a similar output:
> sles11-s390x:~ # dasdinfo -e -a -d /dev/dasda
> ID_BUS=ccw
> ID_TYPE=disk
> ID_UID=HRC.ZZ000000000001.0120.22
> ID_XUID=HRC.ZZ000000000001.0120.22
> ID_SERIAL=0X0122
> 
> sles11-s390x:~ # grep ID_UID  /etc/udev/rules.d/59-dasd.rules
> KERNEL=="dasd*[!0-9]", ENV{ID_UID}=="?*", SYMLINK+="disk/by-id/$env{ID_BUS}-$env{ID_UID}"
> KERNEL=="dasd*[0-9]", ENV{ID_UID}=="?*", SYMLINK+="disk/by-id/$env{ID_BUS}-$env{ID_UID}-part%n"
> 
Primary reason here is that DASDs already had an ID_SERIAL, which
happens to contain the disk number. Which unfortunately is _not_ unique,
but rather per guest. So we had to come up with a different identifier
here to get persistent _and_ unique WWIDs.

(And there also the thingie with IBMs GDPRS, which requires us to have
completely different WWIDs, too. But let's not be sidetracked here).

> 
> It was used for dasd devices in multipath-tools because they haven't a WWN.
> 
Well... As mentioned above, they have one _now_ (that's the
ID_UID/ID_XUID above). But by the time we've been doing the persistent
names they didn't.

I would rather make sure Ceph/RBD has a sysfs attribute somewhere which
contains a unique number.
And then we could code a similar thing like we did for SCSI with the
vpd83 access to get the WWID.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

      reply	other threads:[~2016-07-11  6:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07 21:21 [Question] udev ID_UID attribute ??? Xose Vazquez Perez
2016-07-08 15:52 ` Mike Christie
2016-07-08 20:45   ` Xose Vazquez Perez
2016-07-11  6:40     ` Hannes Reinecke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57833F72.30304@suse.de \
    --to=hare@suse.de \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    --cc=mchristi@redhat.com \
    --cc=xose.vazquez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox