From: Mike Christie <mchristi@redhat.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"christophe.varoqui@opensvc.com" <christophe.varoqui@opensvc.com>
Subject: Re: [PATCH 2/4] multipath-tools: add checker callout to repair path
Date: Fri, 12 Aug 2016 11:54:38 -0500 [thread overview]
Message-ID: <57ADFF4E.2070604@redhat.com> (raw)
In-Reply-To: <e4286ca9-01cb-5cc0-2d67-38f68c0a19cb@sandisk.com>
On 08/11/2016 04:41 PM, Bart Van Assche wrote:
> On 08/11/2016 01:33 PM, Mike Christie wrote:
>> Could you try the attached patch. I found two segfaults. If check_path
>> returns less than 0 then we free the path and so we cannot call repair
>> on it. If libcheck_init fails it memsets the checker, so we cannot call
>> repair on it too.
>>
>> I moved the repair call to the specific paths that the path is down.
>
> Hello Mike,
>
> Thanks for the patch. Unfortunately even with this patch applied I can
> still trigger a segfault sporadically:
>
I can't seem to replicate the problem with my patch and I do not see
anything. Could you send me your multipath.conf/hwtable settings?
For the fo/fb test, dev_loss_tmo is firing causing paths to be
added/deleted right?
next prev parent reply other threads:[~2016-08-12 16:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 12:01 PATCH 0/4] multipath-tools: Ceph rbd support v2 Mike Christie
2016-08-08 12:01 ` [PATCH 1/4] libmultipath: add rbd discovery Mike Christie
2016-08-08 12:01 ` [PATCH 2/4] multipath-tools: add checker callout to repair path Mike Christie
2016-08-11 15:50 ` Bart Van Assche
2016-08-11 20:33 ` Mike Christie
2016-08-11 21:41 ` Bart Van Assche
2016-08-12 16:54 ` Mike Christie [this message]
2016-08-12 17:10 ` Bart Van Assche
2016-08-14 8:41 ` Mike Christie
2016-08-15 16:24 ` Bart Van Assche
2016-08-08 12:01 ` [PATCH 3/4] multipath-tools: Add rbd checker Mike Christie
2016-08-08 12:01 ` [PATCH 4/4] multipath-tools: Add rbd to the hwtable Mike Christie
2016-08-09 15:36 ` PATCH 0/4] multipath-tools: Ceph rbd support v2 Christophe Varoqui
2016-08-09 18:26 ` Mike Christie
2016-08-10 7:55 ` Christophe Varoqui
2016-08-10 15:42 ` Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2016-07-05 8:12 [PATCH 0/4] multipath-tools: Ceph rbd support Mike Christie
2016-07-05 8:12 ` [PATCH 2/4] multipath-tools: add checker callout to repair path Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57ADFF4E.2070604@redhat.com \
--to=mchristi@redhat.com \
--cc=bart.vanassche@sandisk.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).