From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Wilck Subject: Re: [PATCH resend] multipath-tools: document why dev_loss_tmo is set to infinity for HPE 3PAR Date: Fri, 29 Mar 2019 16:53:25 +0100 Message-ID: <5a96ccac4f8fadfaa2bcafebcc6ee17c46ad68ff.camel@suse.de> References: <20190316223045.21614-1-xose.vazquez@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190316223045.21614-1-xose.vazquez@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Xose Vazquez Perez Cc: DM-DEVEL ML List-Id: dm-devel.ids On Sat, 2019-03-16 at 23:30 +0100, Xose Vazquez Perez wrote: > It's needed by Peer Persistence, documented in SLES and RHEL guides: > https://support.hpe.com/hpsc/doc/public/display?docId=a00053835 > https://support.hpe.com/hpsc/doc/public/display?docId=c04448818 > > Cc: Christophe Varoqui > Cc: DM-DEVEL ML > Signed-off-by: Xose Vazquez Perez > --- > libmultipath/hwtable.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > index d3a8d9b..543bacd 100644 > --- a/libmultipath/hwtable.c > +++ b/libmultipath/hwtable.c > @@ -116,6 +116,7 @@ static struct hwentry default_hw[] = { > .prio_name = PRIO_ALUA, > .no_path_retry = 18, > .fast_io_fail = 10, > + /* infinity is needed by Peer Persistence */ > .dev_loss = MAX_DEV_LOSS_TMO, > }, > { I'm not quite getting the benefit of adding this comment without further explanation what Peer Persistence is. Also, IMO, setting dev_loss_tmo to a higher value than the default (contrary to lowering it) doesn't require much justification. But it can't really hurt, so: Reviewed-by: Martin Wilck