From: Jens Axboe <axboe@kernel.dk>
To: Mike Snitzer <snitzer@redhat.com>
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com,
Mikulas Patocka <mpatocka@redhat.com>
Subject: Re: [PATCH v3 0/7] per-cpu in_flight counters for bio-based drivers
Date: Wed, 5 Dec 2018 19:43:54 -0700 [thread overview]
Message-ID: <5d4f6fc4-5d17-294d-5d07-38a4b8a0c19c@kernel.dk> (raw)
In-Reply-To: <20181205202433.95823-1-snitzer@redhat.com>
On 12/5/18 1:24 PM, Mike Snitzer wrote:
> Hi,
>
> This v3 adds "block: stop passing 'cpu' to all percpu stats methods"
> before switching over to percpu counters.
I gave this a shot, with the hope of being able to use it for blk-mq
as well. The tldr is that it's still slower than the tag iteration,
but that isn't a show stopper for a generic implementation. But
unfortunately it fails for queue size results, iostat just shows
0 for the average queue size.
--
Jens Axboe
prev parent reply other threads:[~2018-12-06 2:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 20:24 [PATCH v3 0/7] per-cpu in_flight counters for bio-based drivers Mike Snitzer
2018-12-05 20:24 ` [PATCH v3 1/7] dm: dont rewrite dm_disk(md)->part0.in_flight Mike Snitzer
2018-12-05 20:24 ` [PATCH v3 2/7] dm rq: leverage blk_mq_queue_busy() to check for outstanding IO Mike Snitzer
2018-12-05 20:24 ` [PATCH v3 3/7] block: stop passing 'cpu' to all percpu stats methods Mike Snitzer
2018-12-05 20:24 ` [PATCH v3 4/7] block: delete part_round_stats and switch to less precise counting Mike Snitzer
2018-12-05 20:24 ` [PATCH v3 5/7] block: switch to per-cpu in-flight counters Mike Snitzer
2018-12-05 20:24 ` [PATCH v3 6/7] block: return just one value from part_in_flight Mike Snitzer
2018-12-05 20:24 ` [PATCH v3 7/7] dm: remove the pending IO accounting Mike Snitzer
2018-12-06 2:43 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d4f6fc4-5d17-294d-5d07-38a4b8a0c19c@kernel.dk \
--to=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox