From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: Missing patches
Date: Thu, 23 Jun 2016 20:06:24 +0200 [thread overview]
Message-ID: <649b7736-209c-68c5-ea2e-bd6017fcc28a@gmail.com> (raw)
In-Reply-To: <CABr-Gndm2Mm1wfrmviHLdcaz0_X9o+k062Ggf4rg6w=6PDOXaA@mail.gmail.com>
On 06/20/2016 01:35 PM, Christophe Varoqui wrote:
> For "replace spaces with tabs in defaults.h" I was deferring, in doubt
> : seems to be a coding style issue. Is the tabbed format agreed on with
> other maintainers ?
Right now it's a mess:
$ sed -e 's/ /-space-/g' -e 's/\t/-tabulator-/g' libmultipath/defaults.h
#define-space-DEFAULT_UID_ATTRIBUTE-tabulator-"ID_SERIAL"
#define-space-DEFAULT_UDEVDIR-tabulator--tabulator-"/dev"
#define-space-DEFAULT_MULTIPATHDIR-tabulator-"/"-space-LIB_STRING-space-"/multipath"
#define-space-DEFAULT_SELECTOR-tabulator-"service-time-space-0"
#define-space-DEFAULT_ALIAS_PREFIX-tabulator-"mpath"
#define-space-DEFAULT_FEATURES-tabulator-"0"
#define-space-DEFAULT_HWHANDLER-tabulator-"0"
#define-space-DEFAULT_MINIO-tabulator--tabulator-1000
#define-space-DEFAULT_MINIO_RQ-tabulator-1
#define-space-DEFAULT_PGPOLICY-space--space--space--space--space--space--space-FAILOVER
#define-space-DEFAULT_FAILBACK-space--space--space--space--space--space--space--FAILBACK_MANUAL
#define-space-DEFAULT_RR_WEIGHT-space--space--space--space--space--space-RR_WEIGHT_NONE
#define-space-DEFAULT_NO_PATH_RETRY-space--space-NO_PATH_RETRY_UNDEF
#define-space-DEFAULT_VERBOSITY-tabulator-2
#define-space-DEFAULT_REASSIGN_MAPS-tabulator-0
#define-space-DEFAULT_FIND_MULTIPATHS-tabulator-0
#define-space-DEFAULT_FAST_IO_FAIL-tabulator-5
#define-space-DEFAULT_DEV_LOSS_TMO-space--space--space-600
#define-space-DEFAULT_RETAIN_HWHANDLER-space-RETAIN_HWHANDLER_OFF
#define-space-DEFAULT_DETECT_PRIO-space-DETECT_PRIO_OFF
#define-space-DEFAULT_DEFERRED_REMOVE-space-DEFERRED_REMOVE_OFF
#define-space-DEFAULT_DELAY_CHECKS-space-DELAY_CHECKS_OFF
#define-space-DEFAULT_UEVENT_STACKSIZE-space-256
#define-space-DEFAULT_RETRIGGER_DELAY-space-10
#define-space-DEFAULT_RETRIGGER_TRIES-space-3
#define-space-DEFAULT_UEV_WAIT_TIMEOUT-space-30
#define-space-DEFAULT_CHECKINT-tabulator-5
#define-space-MAX_CHECKINT(a)-tabulator--tabulator-(a-space-<<-space-2)
#define-space-MAX_DEV_LOSS_TMO-tabulator-0x7FFFFFFF
#define-space-DEFAULT_PIDFILE-tabulator--tabulator-"/"-space-RUN_DIR-space-"/multipathd.pid"
#define-space-DEFAULT_SOCKET-tabulator--tabulator-"/org/kernel/linux/storage/multipathd"
#define-space-DEFAULT_CONFIGFILE-tabulator-"/etc/multipath.conf"
#define-space-DEFAULT_BINDINGS_FILE-tabulator-"/etc/multipath/bindings"
#define-space-DEFAULT_WWIDS_FILE-tabulator-"/etc/multipath/wwids"
#define-space-DEFAULT_CONFIG_DIR-tabulator-"/etc/multipath/conf.d"
char-space-*-space-set_default-space-(char-space-*-space-str);
> I wouldn't want to go in a patch-revert loop over this ;)
With git it's easy: https://www.atlassian.com/git/tutorials/undoing-changes/
prev parent reply other threads:[~2016-06-23 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 7:35 hwtable janitoring Christophe Varoqui
2016-06-20 7:55 ` Xose Vazquez Perez
2016-06-20 8:03 ` Christophe Varoqui
2016-06-20 11:06 ` Missing patches Xose Vazquez Perez
2016-06-20 11:35 ` Christophe Varoqui
2016-06-23 18:06 ` Xose Vazquez Perez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=649b7736-209c-68c5-ea2e-bd6017fcc28a@gmail.com \
--to=xose.vazquez@gmail.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).