From: Mikulas Patocka <mpatocka@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Christoph Hellwig <hch@infradead.org>,
Li Nan <linan666@huaweicloud.com>,
dm-devel@redhat.com, Zdenek Kabelac <zkabelac@redhat.com>
Subject: Re: [dm-devel] [PATCH v2 0/3] brd discard patches
Date: Fri, 21 Jul 2023 17:10:56 +0200 (CEST) [thread overview]
Message-ID: <67d28762-d41a-4f67-7e11-de7040bfb369@redhat.com> (raw)
In-Reply-To: <6f0b9cbb-6752-6dd8-c184-10798533dfed@kernel.dk>
On Fri, 21 Jul 2023, Jens Axboe wrote:
> On 7/21/23 7:48?AM, Mikulas Patocka wrote:
> > This is a new version of the brd discard patches.
>
> Can you please:
>
> 1) Ensure that your postings thread properly, it's all separate emails
> and the patches don't nest under the cover letter parent.
I use alpine. I was testing it - and it turns out that when I delete the
last character in the "Subject" field, it deletes the field "In-Reply-To"
from the header. This must be some new bug/feature - it didn't do it in
the past.
I'll try to be more careful to not make the "Subject" field empty when
sending patches.
> 2) Include a changelog. What changed since v1?
>
> --
> Jens Axboe
ChangeLog:
* Batch discarded pages into the "free_page_batch" structure and free all
of them with just one "call_rcu" call. In case of allocation failure,
fall back to per-page "call_rcu" calls. (suggested by Christoph Hellwig)
* Make the module parameter "/sys/module/brd/parameters/discard"
changeable at runtime. Changing it will iterate over all ramdisk devices
and call brd_set_discard_limits on them to enable or disable discard.
(suggested by Christoph Hellwig)
* Use "switch (bio_op(bio))" in brd_submit_bio, so that the code looks
better. (suggested by Chaitanya Kulkarni)
* do "bio->bi_status = BLK_STS_NOTSUPP" in brd_submit_bio if unknown type
of bio is received.
Mikulas
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2023-07-21 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 13:48 [dm-devel] [PATCH v2 0/3] brd discard patches Mikulas Patocka
2023-07-21 14:00 ` Jens Axboe
2023-07-21 15:10 ` Mikulas Patocka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d28762-d41a-4f67-7e11-de7040bfb369@redhat.com \
--to=mpatocka@redhat.com \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linan666@huaweicloud.com \
--cc=linux-block@vger.kernel.org \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).