dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: Benjamin Marzinski <bmarzins@redhat.com>, Martin Wilck <mwilck@suse.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>,
	DM-DEVEL ML <dm-devel@lists.linux.dev>
Subject: Re: [PATCH] multipath-tools: replace round-robin path selector with the default for NFINIDAT/InfiniBox
Date: Sat, 16 Aug 2025 12:22:09 +0200	[thread overview]
Message-ID: <6c8078a2-4f59-4cc0-9548-eee37f4b0e40@gmail.com> (raw)
In-Reply-To: <aCIr3r6KqyumN4Pt@redhat.com>

On 5/12/25 7:11 PM, Benjamin Marzinski wrote:

> On Fri, May 09, 2025 at 04:22:40PM +0200, Martin Wilck wrote:
>> On Fri, 2025-05-09 at 16:08 +0200, Martin Wilck wrote:
>>>
>>> This code is from 55da608 ("libmultipath: update INFINIDAT builtin
>>> config"), signed-off by arnony@infinidat.com. We usually don't change
>>> defaults from explicit vendor recommendations without consent from
>>> the
>>> vendor. I've added Arnon to cc, maybe he wants to comment on your
>>> suggestion.
>>
>> Arnon's email address bounces. Unless we find someone else from
>> Infinidat to comment, I think we should keep the current default. Users
>> are free to override the defaults if the aren't happy with the
>> performance.
> 
> I agree. This device config was set to round-robin after we switched the
> default to service-time, so I think it's reasonable to assume that this
> was intentional. Barring an email or updated documentation from
> INFINIDAT that shows it's no longer the recommended config, I feel like
> we should leave it as is.

At Infinidat support site(user required), there are new configs for SLES 15 and RHEL 8, or above:
https://lh3.googleusercontent.com/pw/AP1GczPhlOIUXYWsuCYQJ42ORS_77xnwTmlN02ZkDU4__6jAvQ_6bBLvvcFsQ9luhSMcB887pXZOaVCrCNZUITTl8eEztD7l568BTSNHL2cB9Dh2SfAAXye7K9Tu8nkjCKMkhQM4H7LRiY4Rp0ygQqCrMmM=w0-h0
https://lh3.googleusercontent.com/pw/AP1GczMchJ6bcMIohp_g3Ik5DS6BZv_IW0iwaEXf968sJsR8fr_p3mR4ThRpmHpZE_VMnlcV8j0uuuI2kz-eoqekRCUBxyTBKS7n-4WFMsUiecq8i7nIjEuhfZFrV54DBQLDzGt6ofakAAF1L-ZcAuCWW18=w0-h0

device {
    vendor "NFINIDAT"
    product "InfiniBox"
    path_grouping_policy "group_by_prio"
    path_checker "tur"
    features 0
    hardware_handler "1 alua"
    prio "alua"
    rr_weight "priorities"
    no_path_retry "queue"
    rr_min_io 1
    rr_min_io_rq 1
    flush_on_last_del "yes"
    fast_io_fail_tmo 15
    dev_loss_tmo "infinity"
    path_selector "service-time 0"
    failback "immediate"
    detect_prio "no"
    user_friendly_names "no"
   }

I will send a new patch.

      reply	other threads:[~2025-08-16 10:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09 13:44 [PATCH] multipath-tools: replace round-robin path selector with the default for NFINIDAT/InfiniBox Xose Vazquez Perez
2025-05-09 14:08 ` Martin Wilck
2025-05-09 14:21   ` Xose Vazquez Perez
2025-05-09 14:22   ` Martin Wilck
2025-05-12 17:11     ` Benjamin Marzinski
2025-08-16 10:22       ` Xose Vazquez Perez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c8078a2-4f59-4cc0-9548-eee37f4b0e40@gmail.com \
    --to=xose.vazquez@gmail.com \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=mwilck@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).