From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 0/2] scsi: core: regression fixes for request batching Date: Wed, 7 Aug 2019 18:17:10 +0200 Message-ID: <700f3175-561a-c577-0cb7-3f9ae4d82db0@redhat.com> References: <20190807144948.28265-1-maier@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190807144948.28265-1-maier@linux.ibm.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Steffen Maier , "James E . J . Bottomley" , "Martin K . Petersen" , Ming Lei Cc: Jens Axboe , linux-s390@vger.kernel.org, Benjamin Block , Vasily Gorbik , linux-scsi@vger.kernel.org, Mike Snitzer , Heiko Carstens , Hannes Reinecke , "Ewan D . Milne" , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-next@vger.kernel.org, Christoph Hellwig , Bart Van Assche List-Id: dm-devel.ids On 07/08/19 16:49, Steffen Maier wrote: > Hi James, Martin, Paolo, Ming, > > multipathing with linux-next is broken since 20190723 in our CI. > The patches fix a memleak and a severe dh/multipath functional regression. > It would be nice if we could get them to 5.4/scsi-queue and also next. > > I would have preferred if such a new feature had used its own > new copy scsi_mq_ops_batching instead of changing the use case and > semantics of the existing scsi_mq_ops, because this would likely > cause less regressions for all the other users not using the new feature. > > Steffen Maier (2): > scsi: core: fix missing .cleanup_rq for SCSI hosts without request > batching > scsi: core: fix dh and multipathing for SCSI hosts without request > batching > > drivers/scsi/scsi_lib.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Paolo Bonzini