Re: [PATCH 4/4] multipathd: don't resend change events for unknown devices

[Martin Wilck <mwilck@suse.de>]

On Thu, 2019-02-07 at 17:53 -0600, Benjamin Marzinski wrote:
> If multipath fails to get the wwid for a device, and the device is
> of an unknown type (pp->bus == SYSFS_BUS_UNDEF), don't send change
> events. Instead, assume that the device was not meant to be used
> and skip it.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>

Reviewed-by: Martin Wilck <mwilck@suse.com>

> ---
>  libmultipath/discovery.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
> index 6aef188..10bd8cd 100644
> --- a/libmultipath/discovery.c
> +++ b/libmultipath/discovery.c
> @@ -1966,6 +1966,8 @@ int pathinfo(struct path *pp, struct config
> *conf, int mask)
>  	if ((mask & DI_WWID) && !strlen(pp->wwid)) {
>  		get_uid(pp, path_state, pp->udev);
>  		if (!strlen(pp->wwid)) {
> +			if (pp->bus == SYSFS_BUS_UNDEF)
> +				return PATHINFO_SKIPPED;
>  			if (pp->initialized != INIT_FAILED) {
>  				pp->initialized = INIT_MISSING_UDEV;
>  				pp->tick = conf->retrigger_delay;