From: NeilBrown <neilb@suse.com>
To: Mike Snitzer <snitzer@redhat.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [dm-devel] [LSF/MM TOPIC] block, dm: restack queue_limits
Date: Fri, 02 Feb 2018 16:59:55 +1100 [thread overview]
Message-ID: <87607g2ap0.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20180129210836.GA5744@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]
On Mon, Jan 29 2018, Mike Snitzer wrote:
> We currently don't restack the queue_limits if the lowest, or
> intermediate, layer of an IO stack changes.
>
> This is particularly unfortunate in the case of FLUSH/FUA which may
> change if/when a HW controller's BBU fails; whereby requiring the device
> advertise that it has a volatile write cache (WCE=1).
>
> But in the context of DM, really it'd be best if the entire stack of
> devices had their limits restacked if any underlying layer's limits
> change.
>
> In the past, Martin and I discussed that we should "just do it" but
> never did. Not sure we need a lengthy discussion but figured I'd put it
> out there.
So much "yes"!!
Just a notifier chain would probably do.
I would like the notification to support changing the size of the device
too.
I see this as being two-stage.
1/ I'm going to change the device size to X - are you all OK with that?
2/ Device size is now X.
That allows md and dm to check that filesystems aren't going to get mad
when devices are made smaller, and can adjust (if they want to) when
devices get bigger.
Thanks,
NeilBrown
>
> Maybe I'll find time, between now and April, to try implementing it.
>
> Thanks,
> Mike
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2018-02-02 5:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 21:08 [LSF/MM TOPIC] block, dm: restack queue_limits Mike Snitzer
2018-01-30 15:07 ` [dm-devel] " Hannes Reinecke
2018-01-30 18:49 ` Ewan D. Milne
2018-02-02 5:59 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87607g2ap0.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).