From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB4BEC47082 for ; Wed, 26 May 2021 11:00:41 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57BA3613F4 for ; Wed, 26 May 2021 11:00:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57BA3613F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-445-DMjcsoSTNLyl2rLskhgQyQ-1; Wed, 26 May 2021 07:00:34 -0400 X-MC-Unique: DMjcsoSTNLyl2rLskhgQyQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 843116D4E3; Wed, 26 May 2021 11:00:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5AEC5629DA; Wed, 26 May 2021 11:00:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 038F11800BBE; Wed, 26 May 2021 11:00:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14PLtMwk005562 for ; Tue, 25 May 2021 17:55:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id 33FB42087A4E; Tue, 25 May 2021 21:55:22 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2E77B2087A35 for ; Tue, 25 May 2021 21:55:19 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ED7EB80D0E9 for ; Tue, 25 May 2021 21:55:18 +0000 (UTC) Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28--IZtGEJDO_-bBaso9JoY-g-1; Tue, 25 May 2021 17:55:16 -0400 X-MC-Unique: -IZtGEJDO_-bBaso9JoY-g-1 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14PJ6iYE179690; Tue, 25 May 2021 19:10:06 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 38q3q8xgg6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 May 2021 19:10:06 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14PJ51ew098258; Tue, 25 May 2021 19:10:05 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2170.outbound.protection.outlook.com [104.47.57.170]) by aserp3020.oracle.com with ESMTP id 38rehau06k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 May 2021 19:10:05 +0000 Received: from SN6PR10MB2943.namprd10.prod.outlook.com (2603:10b6:805:d4::19) by SN6PR10MB3024.namprd10.prod.outlook.com (2603:10b6:805:d1::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.28; Tue, 25 May 2021 19:10:02 +0000 Received: from SN6PR10MB2943.namprd10.prod.outlook.com ([fe80::168:1a9:228:46f3]) by SN6PR10MB2943.namprd10.prod.outlook.com ([fe80::168:1a9:228:46f3%7]) with mapi id 15.20.4150.027; Tue, 25 May 2021 19:10:02 +0000 To: Damien Le Moal , dm-devel@redhat.com, Mike Snitzer , linux-block@vger.kernel.org, Jens Axboe References: <20210525022539.119661-1-damien.lemoal@wdc.com> <20210525022539.119661-5-damien.lemoal@wdc.com> From: Himanshu Madhani Organization: Oracle Message-ID: <8d6ffa67-e21a-a47e-0ac2-a8c0a9403d5f@oracle.com> Date: Tue, 25 May 2021 14:10:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 In-Reply-To: <20210525022539.119661-5-damien.lemoal@wdc.com> X-Originating-IP: [70.114.128.235] X-ClientProxiedBy: SA9PR13CA0004.namprd13.prod.outlook.com (2603:10b6:806:21::9) To SN6PR10MB2943.namprd10.prod.outlook.com (2603:10b6:805:d4::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.28] (70.114.128.235) by SA9PR13CA0004.namprd13.prod.outlook.com (2603:10b6:806:21::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.12 via Frontend Transport; Tue, 25 May 2021 19:10:02 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c8936e9d-46fb-43a9-4a48-08d91fb0b2c0 X-MS-TrafficTypeDiagnostic: SN6PR10MB3024: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: DmjVTrr5PWR3jYHNzZvm+sWSAn3WmyFvGG2P29iSFEw/xNa4qHUPalcWePau9fcQdxUWzq7uLNl5S27X3zlEqVzRZ+E0NXVxPCutXq3tQD0BMgFXE0padfYx88M2++YIASIwju/c2r0Z5oYwlSWPZ0BvMd/qdg6ExMTWrXhgD7FLfCmXlBjuFXvk2nc8c9UGboHvwWWXdujzoeN/L3VuQaRmSlEbO5YTignQUJ1Jm8tVE6iFk1/Wb6ZELVSizflHGumafxVhV/meWyUwjKAFIiAk1aK66oX+lX1/t/6ClTz3NzASMouH6bvGod/ccW9rEMMeDgsu0ZpO0gRTEjQn8SOuNz9PqJ0jfVQYJWSsOk4I3SQT+OmRV9tzo8nSa+9NcCUrsBQUfCc/8yCyYMnHmejiOmRFZHEhdphjYLQPKPxQS4iOErJtRZCmJyKCelvAJX0vUgU5AvvsDbNSMLQDOhxzNtR2g6CCNMAfuBZHlox7KrGZ/gpbF/5mrWR9i/2NkbcRYuNMgdzB66FEg+jf2Nbfx0lCvp2RSouAkK/a7IzAHY7F/M60SrnYfceqI/AMQ1ZY7GWZllx9zTxyizmdmMogeNTwnsWAm1N8eN92WXWbJbEUJic7o1Ps99zuLNPCTnv06akUnnpScIoBIR6sVqzHPZz37w+V0deVf0xzczamOqSIZvGd5B+6K9tHm7tX X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR10MB2943.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(39860400002)(346002)(366004)(136003)(376002)(2616005)(66556008)(66476007)(110136005)(8936002)(26005)(2906002)(83380400001)(6486002)(31696002)(66946007)(31686004)(38100700002)(956004)(186003)(53546011)(86362001)(8676002)(36916002)(44832011)(478600001)(16526019)(16576012)(36756003)(316002)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?TXVpc3FkMTV6eVpKM3YxcmI5Y3RTbVE4NzIwYXBPb0Y5dytyMUY0aVNOK01D?= =?utf-8?B?bGNHemNheHdlY2hnb3BURmxwVnZqa2xDOFJ1S1V0UzJuTzFLK2NLRW9OYUFo?= =?utf-8?B?UTl1aURoQXZPdlptZGhCd0haOXlWbGdHL1RMUDNnTU1QMVJ1eHdzL3JGbExO?= =?utf-8?B?L3RUdUI1QVlEQWRnT0Q5OElqZHhXT0Z3TkFkOXBIaWRKNFYvakhLZG9xUTB3?= =?utf-8?B?RTFObzE2SUtJSGJkWGFabFZsZHJFVFNWT1kxQWpVbjM5ZWNMMndMS04wNnhC?= =?utf-8?B?bmhsRjA5S1J4MjY1aXdPY0NnYmRSR01td09kUFUwczhkdG9hbUFQM0ZQaElF?= =?utf-8?B?Q0R6eWdpZDdSeHdPRE5pNDZUY2tNcGdxR0xPOGcwWmx5TTQ5Y25KRTBSS2Fh?= =?utf-8?B?RVV6U2duaGowZnBxNGRoUFlRU0QrV01MSmZiZG5YYnNrZS9tRXFGeXFaV1ZT?= =?utf-8?B?TEltaHJGN2J2Nk93WmZLY0dLbUpTZGYwZHRuRVZJbE1uWFl2ckpUNEptRlkw?= =?utf-8?B?bVBuZmhxZXNIMWV6R2dQT1JNaVpvSVp1eHFxcTRxbi9WUnZ4Y01DTDJQUVd6?= =?utf-8?B?SW9BbmE1SGVCVmFINGl1emt4UWVEOWZzRmFwRTNreTFXdXoyM2dlL3Y2eCt1?= =?utf-8?B?RWRTSVBPdHNpWjNQTktmeEpPWm9qYmhrL1RKN2VtNHdDTGxhVkRreW00cWRE?= =?utf-8?B?MHBMUmFKaWNFeEJYMm9COWxzc3lSSnA4WWl6SUMzMHJoR1Qxa0J6YWpxT202?= =?utf-8?B?WmVTUi9xYlY2UklYVFg3aEZLTW1iY3lHMGRSbzlDaUl4b3NJT1hmQVNCZEM2?= =?utf-8?B?VGtIbWlMTHEvKzZnSjFURlN3NDg2eFFkdXBTeW9qWlBYeUlFVjFQTjU4SHh5?= =?utf-8?B?UENQcVMrSXpMRnRRQlV2QmFVY1hrdWljU3U2L3lLODZYODN3bmUzbWNnaVpW?= =?utf-8?B?VUkwWWhkZlhvalA0Sy9ielp5RENJMEg4T0F4Vy80K29CWGNnTlRiaHVGUVdm?= =?utf-8?B?QU93ZVU0WWRQYm0zTG1mN25JbHhNYktxWGo2M0d2bXpuL0ozdk10cTg2bDVD?= =?utf-8?B?RVhBcXZOam1DSlNhNW1lQVViY1VQMTEyc0NjRWowNG9FaXJhbkphczZDRXNE?= =?utf-8?B?TisyQ2hxTS8xV1dydGpaWmxvaHMvaElWdTJ1VkdxWWVGOWdrQ0dTbWpjSWxJ?= =?utf-8?B?eEN0dVZKUDdPU1cyN1JGN2ZXUDNIeU1UNmhMb21CNzVWMWNweVdpWGFzeDEv?= =?utf-8?B?a2JMN3AvOVlOMkFVQ1k3OGNybUh0RzErQS9wWmM4eHFyMC9HcHp3SDMvT0hi?= =?utf-8?B?MkM4bHFUcWJNeW9ITXMrMlNEcWxqWkFTK2JDSTVCcGRiN0dFdXFSd25PRU9t?= =?utf-8?B?ZmtGdjI4M3RhNXJMWFdrbDRJWXJkZ0ZWTjBKbkhyTlhhL2VzSDkzcGdkdlI4?= =?utf-8?B?d0R3NEtRenZBNVdQMjdHMDNXT2RndWU3NnVpbHh3bWk5K3NtSkpmUUh4M3hV?= =?utf-8?B?ejMvUldyZ3VOYUlQWVlwUTZiQVM4ZUJJdGpFZi9ELzFyNDd0Ry9lYnZwVE10?= =?utf-8?B?dzhuNk9KcnpyUnRHcU1kaDFxWUt0dVBkaE5RY1BmU05NY1habHJQblBFWVB2?= =?utf-8?B?cTlpWnNMODk5clRaZmU4SjhGWFZJVHZxbzVLSk1LUVVDblFEUnpIY21BSTJm?= =?utf-8?B?YS9JY2dhSytJMFZDZmJoR3lzc2IxYlJxOWJvSDZWMHVkb29tSEJqcFFKOCtM?= =?utf-8?Q?0M4+5rHmaD4zQGpUuLDr8tPW6NMY7W3rR8Z3bBq?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8936e9d-46fb-43a9-4a48-08d91fb0b2c0 X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2943.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2021 19:10:02.3907 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DL9Cv6Hj/UW2G9QPFb3iFUtl9+i+8APFGuozCR5FkJ66TcnSFKA2uR58ypCtk+/Dpv8VjiUv0Y3pj/kEVWcYQkj2bakKt8nEGiaLetVqjB4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB3024 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9995 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105250117 X-Proofpoint-GUID: hYpaZiZ9CwcjPuJUY5yfKDt28uL8jfIq X-Proofpoint-ORIG-GUID: hYpaZiZ9CwcjPuJUY5yfKDt28uL8jfIq X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9995 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 clxscore=1015 malwarescore=0 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 adultscore=0 priorityscore=1501 mlxlogscore=999 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105250117 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Wed, 26 May 2021 06:59:53 -0400 Subject: Re: [dm-devel] [PATCH v4 04/11] dm: Fix dm_accept_partial_bio() X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" On 5/24/21 9:25 PM, Damien Le Moal wrote: > Fix dm_accept_partial_bio() to actually check that zone management > commands are not passed as explained in the function documentation > comment. Also, since a zone append operation cannot be split, add > REQ_OP_ZONE_APPEND as a forbidden command. > > White lines are added around the group of BUG_ON() calls to make the > code more legible. > > Signed-off-by: Damien Le Moal > Reviewed-by: Johannes Thumshirn > Reviewed-by: Hannes Reinecke > --- > drivers/md/dm.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/dm.c b/drivers/md/dm.c > index ca2aedd8ee7d..a9211575bfed 100644 > --- a/drivers/md/dm.c > +++ b/drivers/md/dm.c > @@ -1237,8 +1237,9 @@ static int dm_dax_zero_page_range(struct dax_device *dax_dev, pgoff_t pgoff, > > /* > * A target may call dm_accept_partial_bio only from the map routine. It is > - * allowed for all bio types except REQ_PREFLUSH, REQ_OP_ZONE_RESET, > - * REQ_OP_ZONE_OPEN, REQ_OP_ZONE_CLOSE and REQ_OP_ZONE_FINISH. > + * allowed for all bio types except REQ_PREFLUSH, zone management operations > + * (REQ_OP_ZONE_RESET, REQ_OP_ZONE_OPEN, REQ_OP_ZONE_CLOSE and > + * REQ_OP_ZONE_FINISH) and zone append writes. > * > * dm_accept_partial_bio informs the dm that the target only wants to process > * additional n_sectors sectors of the bio and the rest of the data should be > @@ -1268,9 +1269,13 @@ void dm_accept_partial_bio(struct bio *bio, unsigned n_sectors) > { > struct dm_target_io *tio = container_of(bio, struct dm_target_io, clone); > unsigned bi_size = bio->bi_iter.bi_size >> SECTOR_SHIFT; > + > BUG_ON(bio->bi_opf & REQ_PREFLUSH); > + BUG_ON(op_is_zone_mgmt(bio_op(bio))); > + BUG_ON(bio_op(bio) == REQ_OP_ZONE_APPEND); > BUG_ON(bi_size > *tio->len_ptr); > BUG_ON(n_sectors > bi_size); > + > *tio->len_ptr -= bi_size - n_sectors; > bio->bi_iter.bi_size = n_sectors << SECTOR_SHIFT; > } > Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel