From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Mike Snitzer <msnitzer@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [dm-devel] [PATCH v2] dm-kcopyd: avoid useless atomic operations
Date: Thu, 27 May 2021 08:45:48 +0100 [thread overview]
Message-ID: <YK9OLO6Pc1b13dRj@infradead.org> (raw)
In-Reply-To: <DM6PR04MB70817B208C96D2F568927EA3E7239@DM6PR04MB7081.namprd04.prod.outlook.com>
On Thu, May 27, 2021 at 05:21:24AM +0000, Damien Le Moal wrote:
> > - unsigned long flags;
> > + unsigned flags;
>
> This triggers a checkpatch warning. "unsigned int" would be better.
No, it wouldn't. checkpatch is completely full of shit as usual.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2021-05-27 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 19:49 [dm-devel] [PATCH] dm-kcopyd: avoid useless atomic operations Mikulas Patocka
2021-05-25 22:11 ` Damien Le Moal
2021-05-26 14:16 ` [dm-devel] [PATCH v2] " Mikulas Patocka
2021-05-27 5:21 ` Damien Le Moal
2021-05-27 7:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK9OLO6Pc1b13dRj@infradead.org \
--to=hch@infradead.org \
--cc=Damien.LeMoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
--cc=msnitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).