From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F7E1C7EE23 for ; Wed, 7 Jun 2023 06:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686120541; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=GAhPfZj+6tYweZ62xmzDckpc69q3sF93MQeSoIecaI0=; b=gxloUqiekULXPJf/toVBHT4bLtwKTVHRwVe0zvQNcqgFC4POr9VFVIjCJa3eShc9SL9dMu 4Q19JgMigYTvxwu5svYbPLE+4CS08MZeQ0VaorgCVMFTgstONOsBbtMeQk6bFfN3KnT0vB ZfyjQwhIV6FoulUCqFDmUlG6Fr+RMlA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-591-nexzek0GMduvTWbE8oS6hQ-1; Wed, 07 Jun 2023 02:48:58 -0400 X-MC-Unique: nexzek0GMduvTWbE8oS6hQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6B2621022F0E; Wed, 7 Jun 2023 06:48:56 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56B77477F61; Wed, 7 Jun 2023 06:48:56 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id AC10819451F5; Wed, 7 Jun 2023 06:48:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2CA0919465BA for ; Tue, 6 Jun 2023 23:01:03 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 12DB6140E956; Tue, 6 Jun 2023 23:01:03 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0B595140E954 for ; Tue, 6 Jun 2023 23:01:03 +0000 (UTC) Received: from us-smtp-inbound-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DE795101A53A for ; Tue, 6 Jun 2023 23:01:02 +0000 (UTC) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-_Am-z0EqNTSZerqIyx_QHg-1; Tue, 06 Jun 2023 19:01:01 -0400 X-MC-Unique: _Am-z0EqNTSZerqIyx_QHg-1 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-3f6e68cc738so56629905e9.1 for ; Tue, 06 Jun 2023 16:01:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686092460; x=1688684460; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4AyxSeVCWLu668XQQXcZmNRbTvqm+XfWnbYRI3bfM+o=; b=HYl7gwupHpsAnb52Q3vBRK9io4chvHioUuiuiZ6LBI9NpvkfyfGVYvc9jINGqHzCwK 14GSzepRNm08dVV23gSwtFFvgdyidMZQ5WVfTiDicYWT3s8r21NripjpUidpxlkOhWTw WuJsA0AdQg+/pLhPMbAJrjNJdZY8U6Zb9pbQ+bWGUyOzq2JqNy+BmSiP1IoSzQuycF2N RJUBWe4KxQhBoD/2EL3B4Mms7MBcQkiiyEhI4FC138NKZe/j7kK6CsqO25kg7xRQabtv 4/QjOZ8hAF2UnoqbX30DUtNrODQR6x5O33zpjb+apIGubI1cH40GpNZVOfc6I56yYzN4 AZjw== X-Gm-Message-State: AC+VfDwU4zX3UIJBPQq4xJ6NYtMqTiRFXpCHQandUacB+22J3yLAf77q SOu73MwdfFwGK8ydQYbk2keLDg== X-Google-Smtp-Source: ACHHUZ5ZvgvojXp46B2yfDhTglh07h4ImH+yrfGSyDnf68I9NldGnBlDJsUdFl1IxgkatnTdfmUXtg== X-Received: by 2002:a1c:4c0d:0:b0:3f5:6e6:9d83 with SMTP id z13-20020a1c4c0d000000b003f506e69d83mr2830681wmf.23.1686092459976; Tue, 06 Jun 2023 16:00:59 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id u25-20020a7bcb19000000b003f73a101f88sm201447wmj.16.2023.06.06.16.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 16:00:59 -0700 (PDT) Date: Wed, 7 Jun 2023 00:00:57 +0100 From: Phillip Potter To: Christoph Hellwig Message-ID: References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-7-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20230606073950.225178-7-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mailman-Approved-At: Wed, 07 Jun 2023 06:48:52 +0000 Subject: Re: [dm-devel] [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , "Rafael J. Wysocki" , linux-nvme@lists.infradead.org, Phillip Potter , Chris Mason , dm-devel@redhat.com, "Md. Haris Iqbal" , Pavel Machek , Miquel Raynal , Jack Wang , linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , linux-pm@vger.kernel.org, linux-um@lists.infradead.org, Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, Alexander Viro , David Sterba , Jens Axboe , Christian Brauner , "Martin K. Petersen" , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: philpotter.co.uk Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Jun 06, 2023 at 09:39:25AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/cdrom/cdrom.c | 2 +- > drivers/cdrom/gdrom.c | 2 +- > drivers/scsi/sr.c | 2 +- > include/linux/cdrom.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c > index adebac1bd210d9..998b03fe976e22 100644 > --- a/drivers/cdrom/cdrom.c > +++ b/drivers/cdrom/cdrom.c > @@ -1250,7 +1250,7 @@ static int check_for_audio_disc(struct cdrom_device_info *cdi, > return 0; > } > > -void cdrom_release(struct cdrom_device_info *cdi, fmode_t mode) > +void cdrom_release(struct cdrom_device_info *cdi) > { > const struct cdrom_device_ops *cdo = cdi->ops; > > diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c > index 14922403983e9e..a401dc4218a998 100644 > --- a/drivers/cdrom/gdrom.c > +++ b/drivers/cdrom/gdrom.c > @@ -481,7 +481,7 @@ static int gdrom_bdops_open(struct block_device *bdev, fmode_t mode) > bdev_check_media_change(bdev); > > mutex_lock(&gdrom_mutex); > - ret = cdrom_open(gd.cd_info, mode); > + ret = cdrom_open(gd.cd_info); > mutex_unlock(&gdrom_mutex); > return ret; > } > diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c > index 444c7efc14cba7..6d33120ee5ba85 100644 > --- a/drivers/scsi/sr.c > +++ b/drivers/scsi/sr.c > @@ -512,7 +512,7 @@ static void sr_block_release(struct gendisk *disk, fmode_t mode) > struct scsi_cd *cd = scsi_cd(disk); > > mutex_lock(&cd->lock); > - cdrom_release(&cd->cdi, mode); > + cdrom_release(&cd->cdi); > mutex_unlock(&cd->lock); > > scsi_device_put(cd->device); > diff --git a/include/linux/cdrom.h b/include/linux/cdrom.h > index 385e94732b2cf1..3f23d5239de254 100644 > --- a/include/linux/cdrom.h > +++ b/include/linux/cdrom.h > @@ -102,7 +102,7 @@ int cdrom_read_tocentry(struct cdrom_device_info *cdi, > > /* the general block_device operations structure: */ > int cdrom_open(struct cdrom_device_info *cdi, fmode_t mode); > -extern void cdrom_release(struct cdrom_device_info *cdi, fmode_t mode); > +void cdrom_release(struct cdrom_device_info *cdi); > int cdrom_ioctl(struct cdrom_device_info *cdi, struct block_device *bdev, > unsigned int cmd, unsigned long arg); > extern unsigned int cdrom_check_events(struct cdrom_device_info *cdi, > -- > 2.39.2 > Looks good, thanks. Signed-off-by: Phillip Potter Regards, Phil -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel