From: Mike Snitzer <snitzer@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [dm-devel] [PATCH 3/3] block: fail writes to read-only devices
Date: Tue, 6 Jun 2023 12:13:39 -0400 [thread overview]
Message-ID: <ZH9bMx10optlZZlf@redhat.com> (raw)
In-Reply-To: <20230601072829.1258286-4-hch@lst.de>
On Thu, Jun 01 2023 at 3:28P -0400,
Christoph Hellwig <hch@lst.de> wrote:
> Currently callers can happily submit writes to block devices that are
> marked read-only, including to drivers that don't even support writes
> and will crash when fed such bios.
>
> While bio submitter should check for read-only devices, that's not a
> very robust way of dealing with this.
>
> Note that the last attempt to do this got reverted by Linus in commit
> a32e236eb93e ("Partially revert "block: fail op_is_write() requests to
> read-only partitions") because device mapper relyied on not enforcing
> the read-only state when used together with older lvm-tools.
>
> The lvm side got fixed in:
>
> https://sourceware.org/git/?p=lvm2.git;a=commit;h=a6fdb9d9d70f51c49ad11a87ab4243344e6701a3
>
> but if people still have older lvm2 tools in use we probably need
> to find a workaround for this in device mapper rather than lacking
> the core block layer checks.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Snitzer <snitzer@kernel.org>
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2023-06-06 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 7:28 [dm-devel] enforce read-only state at the block layer Christoph Hellwig
2023-06-01 7:28 ` [dm-devel] [PATCH 1/3] block: remove a duplicate bdev_read_only declaration Christoph Hellwig
2023-06-01 7:28 ` [dm-devel] [PATCH 2/3] block: simplify the check for flushes in bio_check_ro Christoph Hellwig
2023-06-01 7:28 ` [dm-devel] [PATCH 3/3] block: fail writes to read-only devices Christoph Hellwig
2023-06-02 1:02 ` Linus Torvalds
2023-06-02 15:41 ` Christoph Hellwig
2023-06-02 15:56 ` Linus Torvalds
2023-06-06 16:13 ` Mike Snitzer [this message]
2023-06-06 16:11 ` [dm-devel] enforce read-only state at the block layer Mike Snitzer
2023-06-07 5:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH9bMx10optlZZlf@redhat.com \
--to=snitzer@kernel.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).