From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB0D5C7EE25 for ; Fri, 9 Jun 2023 07:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686294058; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=X/KWuSmq7Dlyj9pQOJilwqodBQsIdxPtAEanycfUljg=; b=Vz3V4bxX6V0zKFHs8XgOBBQpoqts5cKncIB4rcVs81Rae4kWIYUXivxanUy03dXsxwx0V6 y6gRsaT5fKbYeMJsNxcTSH1CuusRA0ORHpji2hUoof6813ShXUQfERnkavBJzzNe0RQ/EW whlDMgHfzxKQuNczqFOiCr1dKCzZ4rM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-395-1szvA9-SPVKMFZW7BsSL4Q-1; Fri, 09 Jun 2023 03:00:55 -0400 X-MC-Unique: 1szvA9-SPVKMFZW7BsSL4Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 08030185A791; Fri, 9 Jun 2023 07:00:51 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA3D5C16044; Fri, 9 Jun 2023 07:00:50 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CE4C519451C0; Fri, 9 Jun 2023 07:00:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3F8E4194658C for ; Thu, 8 Jun 2023 09:44:26 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 25F609E94; Thu, 8 Jun 2023 09:44:26 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E2039E93 for ; Thu, 8 Jun 2023 09:44:26 +0000 (UTC) Received: from us-smtp-inbound-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F2B5F801182 for ; Thu, 8 Jun 2023 09:44:25 +0000 (UTC) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-sZUhAUd0MfSLb9_XymtsAw-1; Thu, 08 Jun 2023 05:44:24 -0400 X-MC-Unique: sZUhAUd0MfSLb9_XymtsAw-1 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-30c55d2b9f3so278068f8f.2 for ; Thu, 08 Jun 2023 02:44:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686217463; x=1688809463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7UW1P1+u4z8C1yYHhcCc7D6z205h5xRpA4Pis0U9UMY=; b=G5Cwlgab8rZm8iNhCUzHNpbdM45tjKvmayqxXLbaCJ21sxyq17RNahRXeYLol9PVIi 2ihwfXONl5WlAxWvfQSEBqaFSAAOVbdISQX+6ugpHjIIovNZGhlzc+vlpoMBwDhD/Tx1 WsBDZ7EEbRIwf3B2sD0cFw+3z4Nx7p+MQqMHXQzxChgWWiR2aLEVaUYRtIqYJkZY0bqm i2UmkaVb5qY0sW7qJMI/Kb4TPUz6aY36KM1EguFa0U13+qv/4r5WQXMLr57LT99thTz3 tfNM65+wQeKY0RQGatX2SeQ2ucCBsh0CTAdvH+IJZafLPYgLVn1+dng6615lGdRoFZtd 5n3Q== X-Gm-Message-State: AC+VfDxfuDQmIMAyLTsS9T91etGoKSb/gvyMfWlL/9hQXSTDNQk4/Ohl bOCV0NUGh3trxr7miLKYnC3Dpg== X-Google-Smtp-Source: ACHHUZ55+QiuKZDDVF2xerotwpMLkKmO7qQkxSxt7AJ+yBOXmT5EW03OqeXuJJ7vWtahwa0aPclqwA== X-Received: by 2002:adf:e60c:0:b0:30a:e3da:efe5 with SMTP id p12-20020adfe60c000000b0030ae3daefe5mr6178509wrm.32.1686217463182; Thu, 08 Jun 2023 02:44:23 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id c17-20020adffb51000000b00307bc4e39e5sm1027878wrs.117.2023.06.08.02.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 02:44:22 -0700 (PDT) Date: Thu, 8 Jun 2023 10:44:20 +0100 From: Phillip Potter To: Christoph Hellwig Message-ID: References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-7-hch@lst.de> <20230608084129.GA14689@lst.de> <20230608090444.GA15075@lst.de> MIME-Version: 1.0 In-Reply-To: <20230608090444.GA15075@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mailman-Approved-At: Fri, 09 Jun 2023 07:00:46 +0000 Subject: Re: [dm-devel] [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , "Rafael J. Wysocki" , linux-nvme@lists.infradead.org, Chris Mason , dm-devel@redhat.com, "Md. Haris Iqbal" , Pavel Machek , Miquel Raynal , Jack Wang , linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , linux-pm@vger.kernel.org, linux-um@lists.infradead.org, Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, Alexander Viro , David Sterba , Jens Axboe , Christian Brauner , "Martin K. Petersen" , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: philpotter.co.uk Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Jun 08, 2023 at 11:04:44AM +0200, Christoph Hellwig wrote: > On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote: > > Yes indeed - I was under the impression it was appropriate for a > > maintainer to signal their approval of a patch to maintained code using > > a Signed-off-by tag due to their involvement in the submission process? > > Apologies if I've got this wrong, happy to send Reviewed-bys by all > > means. > > Signed-off-by is for the chain that the patches pass through. You add > it when you apply or forward the patch. Just give me a Reviewed-by > tag and say it shold apply to patches 1 to 6 and I'll add it. Thanks for the guidance. Please apply the following to the block patch (1) and the CD-ROM patches (2-6) of your series, all looks good to me: Reviewed-by: Phillip Potter Regards, Phil -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel