From: Andy Grover <agrover@redhat.com>
To: dm-devel@redhat.com
Subject: Re: [PATCH 2/3] dm: Add support to poll for dm events
Date: Mon, 9 Jan 2017 18:10:42 -0800 [thread overview]
Message-ID: <a0dc1add-9260-d3ff-6579-82b49a32a69b@redhat.com> (raw)
In-Reply-To: <20170109182040.31337-3-agrover@redhat.com>
Please see below for some bugs I spotted.
The surest way to find bugs is to post patches to a public list :-/
On 01/09/2017 10:20 AM, Andy Grover wrote:
> +int dm_release(struct inode *inode, struct file *filp)
> + if (priv->md) {
should be "if (priv && priv->md)"
> +static unsigned int dm_poll(struct file *filp, poll_table *wait)
> + if (!priv->md)
should be "if (!priv || !priv->md)"
Regards -- Andy
next prev parent reply other threads:[~2017-01-10 2:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 18:20 [PATCH 0/3] poll() for DM events Andy Grover
2017-01-09 18:20 ` [PATCH 1/3] dm: Change ioctl handlers to take struct file* Andy Grover
2017-01-09 18:20 ` [PATCH 2/3] dm: Add support to poll for dm events Andy Grover
2017-01-10 2:10 ` Andy Grover [this message]
2017-01-09 18:20 ` [PATCH 3/3] dm: Allow associated fd to be used for TABLE_STATUS Andy Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0dc1add-9260-d3ff-6579-82b49a32a69b@redhat.com \
--to=agrover@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox