From: Martin Wilck <martin.wilck@suse.com>
To: "bmarzins@redhat.com" <bmarzins@redhat.com>,
"christophe.varoqui@opensvc.com" <christophe.varoqui@opensvc.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [dm-devel] [PATCH] libmultipath: don't return error on invalid values
Date: Fri, 12 Nov 2021 10:54:33 +0000 [thread overview]
Message-ID: <a30da030d3f003e7a2cf185c0547f53fc86e2fea.camel@suse.com> (raw)
In-Reply-To: <1636680271-27908-1-git-send-email-bmarzins@redhat.com>
On Thu, 2021-11-11 at 19:24 -0600, Benjamin Marzinski wrote:
> do_set_int and set_uint return 1 for invalid values. This can cause
> multipath to fail completely, while reading the config. The config
> handlers should only return a non-zero value if there is an internal
> error, not if there is just an invalid value.
>
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2021-11-12 10:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 1:24 [dm-devel] [PATCH] libmultipath: don't return error on invalid values Benjamin Marzinski
2021-11-12 10:54 ` Martin Wilck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a30da030d3f003e7a2cf185c0547f53fc86e2fea.camel@suse.com \
--to=martin.wilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox