public inbox for dm-devel@redhat.com
 help / color / mirror / Atom feed
From: "Bryn M. Reeves" <bmr@redhat.com>
To: Heinz Mauelshagen <heinzm@redhat.com>
Cc: dm-devel@lists.linux.dev
Subject: Re: [PATCH] dm raid: add takeover/reshape raid1 -> raid5 table line examples
Date: Mon, 1 Dec 2025 16:09:14 +0000	[thread overview]
Message-ID: <aS29qjy6t09KMP3E@redhat.com> (raw)
In-Reply-To: <CAM23VxrJpHE4SBo82AnTwD14qA-GXfs48kfaaoenGAnEqTEUtw@mail.gmail.com>

On Mon, Dec 01, 2025 at 03:40:39PM +0100, Heinz Mauelshagen wrote:
> Also enhance possible takeover/reshape information and do some reformatting.

Patch seems to be line-wrapped at 80 characters. Does not apply:

$ git apply /var/tmp/dm-raid-doc.patch
error: git diff header lacks filename information when removing 1 leading pathname component (line 9)

There seems to be some tabs/space issues also even after fixing the line
breaks:

patching file Documentation/admin-guide/device-mapper/dm-raid.rst
Hunk #1 FAILED at 20.
Hunk #2 FAILED at 48.
Hunk #3 FAILED at 371.
Hunk #4 FAILED at 398.
4 out of 4 hunks FAILED -- saving rejects to file Documentation/admin-guide/device-mapper/dm-raid.rst.rej

Regards,
Bryn.

> ---
>  .../admin-guide/device-mapper/dm-raid.rst     | 49 +++++++++++++++----
>  1 file changed, 39 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/admin-guide/device-mapper/dm-raid.rst
> b/Documentation/admin-guide/device-mapper/dm-raid.rst
> index 3554c44414e63..e11f107647709 100644
> --- a/Documentation/admin-guide/device-mapper/dm-raid.rst
> +++ b/Documentation/admin-guide/device-mapper/dm-raid.rst
> @@ -20,10 +20,10 @@ The target is named "raid" and it accepts the
> following parameters::
>    raid0 RAID0 striping (no resilience)
>    raid1 RAID1 mirroring
>    raid4 RAID4 with dedicated last parity disk
> -  raid5_n RAID5 with dedicated last parity disk supporting takeover
> +  raid5_n RAID5 with dedicated last parity disk supporting takeover
> from/to raid1
>   Same as raid4


      reply	other threads:[~2025-12-01 16:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-01 14:40 [PATCH] dm raid: add takeover/reshape raid1 -> raid5 table line examples Heinz Mauelshagen
2025-12-01 16:09 ` Bryn M. Reeves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aS29qjy6t09KMP3E@redhat.com \
    --to=bmr@redhat.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=heinzm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox