Re: [PATCH] kpartx: fix segfault when operating on regular files

[Benjamin Marzinski <bmarzins@redhat.com>]

On Mon, Jan 26, 2026 at 10:27:07AM -0500, Benjamin Marzinski wrote:
> On Mon, Jan 26, 2026 at 01:13:25PM +0100, Martin Wilck wrote:
> > The following problem has been introduced in multipath-tools 0.14.0:
> >  
> > [snip] 
> > diff --git a/kpartx/kpartx.c b/kpartx/kpartx.c
> > index 9bdd204..cfd8212 100644
> > --- a/kpartx/kpartx.c
> > +++ b/kpartx/kpartx.c
> > @@ -334,8 +334,11 @@ main(int argc, char **argv){
> >  	 * This allows deletion of partitions created with older kpartx
> >  	 * versions which didn't use the fake UUID during creation.
> >  	 */
> > -	if (!uuid && !(what == DELETE && force_devmap))
> > +	if (!uuid && !(what == DELETE && force_devmap)) {
> >  		uuid = nondm_create_uuid(buf.st_rdev);
> > +		if (!uuid)
> 
> We should probably print an error message before we exit, but
> otherwise, this looks good.
> 
> -Ben

After being reminded that there's not much point in trying to print
error messages after failing a memory allocation,

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>

> > +			exit(1);
> > +	}
> >  
> >  	if (delim == NULL) {
> >  		delim = xmalloc(DELIM_SIZE);
> > -- 
> > 2.52.0