From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Busch Subject: Re: [PATCH 01/10] block: make generic_make_request handle arbitrarily sized bios Date: Tue, 28 Apr 2015 16:01:26 +0000 (UTC) Message-ID: References: <1430203717-13307-1-git-send-email-mlin@kernel.org> <1430203717-13307-2-git-send-email-mlin@kernel.org> <20150428114320.GA9790@lst.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Return-path: In-Reply-To: <20150428114320.GA9790@lst.de> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig Cc: Ming Lin , linux-kernel@vger.kernel.org, Jens Axboe , Kent Overstreet , Dongsu Park , Christoph Hellwig , Al Viro , Ming Lei , Neil Brown , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Lars Ellenberg , drbd-user@lists.linbit.com, Jiri Kosina , Geoff Levand , Jim Paris , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Oleg Drokin , Andreas Dilger , Keith Busch List-Id: dm-devel.ids On Tue, 28 Apr 2015, Christoph Hellwig wrote: > This seems to lack support for QUEUE_FLAG_SG_GAPS to work around > the retarded PPR format in the NVMe driver. Might strong words, sir! I'm missing the context here, but I'll say PRP is much more efficient for h/w to process over SGL, and the requirement comes from that h/w rather than the driver.