dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Dongsheng Yang <dongsheng.yang@linux.dev>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: dm-devel@lists.linux.dev
Subject: Re: [bug report] dm-pcache: add persistent cache target in device-mapper
Date: Fri, 29 Aug 2025 18:09:14 +0800	[thread overview]
Message-ID: <c6ac00dd-8356-4402-b68c-79660c751a4e@linux.dev> (raw)
In-Reply-To: <aLFvdA9clSu_i-DC@stanley.mountain>


在 8/29/2025 5:14 PM, Dan Carpenter 写道:
> On Fri, Aug 29, 2025 at 02:03:36PM +0800, Dongsheng Yang wrote:
>> 在 8/29/2025 1:39 PM, Dan Carpenter 写道:
>>> Hello Dongsheng Yang,
>>>
>>> Commit 1d57628ff95b ("dm-pcache: add persistent cache target in
>>> device-mapper") from Aug 12, 2025 (linux-next), leads to the
>>> following Smatch static checker warning:
>>>
>>> 	drivers/md/dm-pcache/cache_segment.c:263 cache_seg_gen_increase()
>>> 	warn: sleeping in atomic context
>>
>> Hi Dan,
>>
>>      Thanx for your report, I will send out the patch after my testing
>> finished.
>>
>> BTW, can you share the Smatch checking command or script? I want to add
>>
>> Smatch check in my testing suit if possible, I did not found this kind of
>> problem with simple:
>>
>> make CHECK="smatch -p=kernel" C=1 M=drivers/md/dm-pcache
>>
> It requires several rebuilds of the cross function database...  Everytime
> you rebuild then it does:
>
> First build: cache_data_alloc() disables preemption calls cache_seg_put()
> Second build: cache_seg_put() calls cache_seg_invalidate()
> Third build: cache_seg_invalidate() calls cache_seg_gen_increase()
>
> Rebuilding the databse takes hours and hours.
>
> ~/path/to/smatch/smatch_scripts/build_kernel_data.sh


Thanx for  your share, I will give it a try, it seems really found issue 
I did not hit in my testing.

>
> regards,
> dan carpenter
>

  reply	other threads:[~2025-08-29 10:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-29  5:39 [bug report] dm-pcache: add persistent cache target in device-mapper Dan Carpenter
2025-08-29  6:03 ` Dongsheng Yang
2025-08-29  9:14   ` Dan Carpenter
2025-08-29 10:09     ` Dongsheng Yang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-08-18  9:52 Dan Carpenter
2025-08-18 14:03 ` Dongsheng Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6ac00dd-8356-4402-b68c-79660c751a4e@linux.dev \
    --to=dongsheng.yang@linux.dev \
    --cc=dan.carpenter@linaro.org \
    --cc=dm-devel@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).