From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH V4 0/2] block/scsi/dm-rq: fix leak of request private data in dm-mpath Date: Sun, 4 Aug 2019 20:42:26 -0700 Message-ID: References: <20190725020500.4317-1-ming.lei@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190725020500.4317-1-ming.lei@redhat.com> Content-Language: en-US Sender: stable-owner@vger.kernel.org To: Ming Lei Cc: linux-block@vger.kernel.org, "Ewan D . Milne" , Bart Van Assche , Hannes Reinecke , Christoph Hellwig , Mike Snitzer , dm-devel@redhat.com, stable@vger.kernel.org List-Id: dm-devel.ids On 7/24/19 7:04 PM, Ming Lei wrote: > Hi, > > When one request is dispatched to LLD via dm-rq, if the result is > BLK_STS_*RESOURCE, dm-rq will free the request. However, LLD may allocate > private data for this request, so this way will cause memory leak. > > Add .cleanup_rq() callback and implement it in SCSI for fixing the issue, > since SCSI is the only driver which allocates private requst data in > .queue_rq() path. > > Another use case of this callback is to free the request and re-submit > bios during cpu hotplug when the hctx is dead, see the following link: > > https://lore.kernel.org/linux-block/f122e8f2-5ede-2d83-9ca0-bc713ce66d01@huawei.com/T/#t Applied for 5.4, thanks. -- Jens Axboe