From: Martin Wilck <martin.wilck@suse.com>
To: "bmarzins@redhat.com" <bmarzins@redhat.com>,
"christophe.varoqui@opensvc.com" <christophe.varoqui@opensvc.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [dm-devel] [PATCH 1/9] libmultipath: steal the src string pointer in merge_str()
Date: Tue, 12 Apr 2022 10:38:29 +0000 [thread overview]
Message-ID: <ca96886df24846438e2d65fcf67c8d911898e3e6.camel@suse.com> (raw)
In-Reply-To: <1649728799-11790-2-git-send-email-bmarzins@redhat.com>
On Mon, 2022-04-11 at 20:59 -0500, Benjamin Marzinski wrote:
> Instead of allocating a copy when the original string is going to be
> freed right after the merge, just steal the pointer. Also,
> merge_mpe()
> can't get called with NULL arguments.
>
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-04-12 10:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 1:59 [dm-devel] [PATCH 0/9] Add protocol specific config subsection Benjamin Marzinski
2022-04-12 1:59 ` [dm-devel] [PATCH 1/9] libmultipath: steal the src string pointer in merge_str() Benjamin Marzinski
2022-04-12 10:38 ` Martin Wilck [this message]
2022-04-12 1:59 ` [dm-devel] [PATCH 2/9] libmultipath: make protocol_name global Benjamin Marzinski
2022-04-12 10:40 ` Martin Wilck
2022-04-12 1:59 ` [dm-devel] [PATCH 3/9] libmultipath: add a protocol subsection to multipath.conf Benjamin Marzinski
2022-04-12 1:59 ` [dm-devel] [PATCH 4/9] libmultipath: Set the scsi timeout parameters by path Benjamin Marzinski
2022-04-12 1:59 ` [dm-devel] [PATCH 5/9] libmultipath: check the hwentry pctable for path variables Benjamin Marzinski
2022-04-12 1:59 ` [dm-devel] [PATCH 6/9] libmultipath: make snprint_pctable indent a variable amount Benjamin Marzinski
2022-04-12 1:59 ` [dm-devel] [PATCH 7/9] libmultipath: add procotol subsection to overrides Benjamin Marzinski
2022-04-12 1:59 ` [dm-devel] [PATCH 8/9] libmultipath: fix eh_deadline documentation Benjamin Marzinski
2022-04-12 1:59 ` [dm-devel] [PATCH 9/9] libmultipath: Add documentation for the protocol subsection Benjamin Marzinski
2022-04-12 10:31 ` [dm-devel] [PATCH 0/9] Add protocol specific config subsection Martin Wilck
2022-04-12 13:18 ` Martin Wilck
2022-04-12 18:47 ` Benjamin Marzinski
2022-04-12 20:47 ` Martin Wilck
2022-04-12 22:01 ` Benjamin Marzinski
2022-04-13 11:03 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca96886df24846438e2d65fcf67c8d911898e3e6.camel@suse.com \
--to=martin.wilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox