From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4CEDC74A5B for ; Wed, 29 Mar 2023 23:34:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680132882; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=H8s7W6mksLO6LITdtHito21C6Gp+oXt2nS+CnXhSM8k=; b=UXFxE6FBVoBVB2uSW6qeA56hl+4eR3tBibFUro1R4iBGFt6NMP1FBCuP0roBqknZLbe3fo a7q8GwGLXoXVTrQ2m4UehtkZTg/xfllZc2cObG/eCqX64K6eOgHUBL+6cAT5sDGt4F9QF2 MyuPwC4Fgjf0dhMky4/KeZQ5fLYwGJ8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-117-PtL3U-zjN1-nTJfjBR9Rpg-1; Wed, 29 Mar 2023 19:34:40 -0400 X-MC-Unique: PtL3U-zjN1-nTJfjBR9Rpg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A8C83185A791; Wed, 29 Mar 2023 23:34:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5602A18EC2; Wed, 29 Mar 2023 23:34:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 20C521946597; Wed, 29 Mar 2023 23:34:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 17B2D1946587 for ; Wed, 29 Mar 2023 23:34:37 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EEF5F18EC6; Wed, 29 Mar 2023 23:34:36 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E6D20440D9 for ; Wed, 29 Mar 2023 23:34:36 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C83EB2814247 for ; Wed, 29 Mar 2023 23:34:36 +0000 (UTC) Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-352-sZBqpdFwPPCmWHKGMRzprA-3; Wed, 29 Mar 2023 19:34:35 -0400 X-MC-Unique: sZBqpdFwPPCmWHKGMRzprA-3 X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="226648289" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:34:32 +0800 IronPort-SDR: mi0CNs4JkIe7fb6QfhasLVHFcyMYHWfM3/iM8eVM145ytfYyT4eYxt7wS0pHzW2h06yg2btDUS EC7SEzYHMD90QD9fQ3e8VlXepbP6BHzKMOWlR4S1lLamSaZnH0mK0Dg/jGu/ioh4QkJO++M7in A/uqXL81TqmaQ2MogeMpxaqu6cOFJ4fFFqV3YwprEnQkqyapctvGLVfK+AGOmKeV6h7j+D14we syuVjCbJUm4+nmdh17WRBltsrr7cjtUOC2jEVaoaBqXgGQUKFej/zk70WMJ7UwQemG+6ATFEbF mj0= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:45:00 -0700 IronPort-SDR: zsOPT+WC+aY/oPH50lN5JFoOubpkRDaOceasAtA7+Za7TVqzqLFjQqWBZ0GLs6/TODy5IX4QwO XJHMdGoILtNZp6JrorkOLu7YURPp7l+Of8lx3qa7HM/GWPqc+A4Fo9yg8jwCrsk0M+tTQR+Ni/ PJalJLwKtpe9DQzy1U9sWK55pakTh24LiNBlaGjJtUdQnAKKGD91+J5DdXqVb1yswPjQXi4x/c s8mnw+M68eikUHhREvkxI3RW2wcqsf+6PeTijYjlLmIRGS4eTtWPwD0x+U9zWwvuAF3sz49tUT t44= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:34:32 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2vW6Ccnz1RtW2 for ; Wed, 29 Mar 2023 16:34:31 -0700 (PDT) X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sOxWjYofwm05 for ; Wed, 29 Mar 2023 16:34:30 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2vS0ZGvz1RtVm; Wed, 29 Mar 2023 16:34:27 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 08:34:27 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: Johannes Thumshirn , Jens Axboe References: <902f83de56c67b333959d8b8b4cf37a25414e927.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <902f83de56c67b333959d8b8b4cf37a25414e927.1680108414.git.johannes.thumshirn@wdc.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Subject: Re: [dm-devel] [PATCH 10/19] jfs: logmgr: use __bio_add_page to add single page to bio X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-raid@vger.kernel.org, jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Chaitanya Kulkarni , Andreas Gruenbacher , Song Liu , Dave Kleikamp , Mike Snitzer , Matthew Wilcox , Ming Lei , linux-block@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, David Sterba , linux-fsdevel@vger.kernel.org, Christoph Hellwig , linux-btrfs@vger.kernel.org, Bob Peterson Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: opensource.wdc.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 3/30/23 02:05, Johannes Thumshirn wrote: > The JFS IO code uses bio_add_page() to add a page to a newly created bio. > bio_add_page() can fail, but the return value is never checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel