From: Hannes Reinecke <hare@suse.de>
To: Martin Wilck <mwilck@suse.com>,
Christophe Varoqui <christophe.varoqui@opensvc.com>,
Guan Junxiong <guanjunxiong@huawei.com>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH v2 2/2] multipathd: start marginal path checker thread lazily
Date: Wed, 7 Mar 2018 08:25:12 +0100 [thread overview]
Message-ID: <d7debc7f-8e2c-704f-eabf-ab9a668f3163@suse.de> (raw)
In-Reply-To: <20180306211842.2556-2-mwilck@suse.com>
On 03/06/2018 10:18 PM, Martin Wilck wrote:
> I noticed that the io_error checker thread accounts for most of the
> activity of multipathd even if the marginal path checking paramters
> are not set (which is still the default in most installations I assume).
>
> Therefore, start the io_error checker thread only if there's at least
> one map with marginal error path checking configured. Also, make sure
> the thread is really up when start_io_err_stat_thread() returns.
>
> This requires adding a "vecs" argument to setup_map, because vecs
> needs to be passed to the io_error checking code.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
> libmultipath/configure.c | 14 +++++++++---
> libmultipath/configure.h | 3 ++-
> libmultipath/io_err_stat.c | 55 ++++++++++++++++++++++++++++++++++++++++++----
> libmultipath/structs_vec.c | 3 ++-
> multipathd/cli_handlers.c | 2 +-
> multipathd/main.c | 8 ++-----
> 6 files changed, 69 insertions(+), 16 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2018-03-07 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180306211842.2556-1-mwilck@suse.com>
2018-03-06 21:18 ` [PATCH v2 2/2] multipathd: start marginal path checker thread lazily Martin Wilck
2018-03-07 7:25 ` Hannes Reinecke [this message]
2018-03-07 7:23 ` [PATCH v2 1/2] libmultipath: fix race in stop_io_err_stat_thread Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7debc7f-8e2c-704f-eabf-ab9a668f3163@suse.de \
--to=hare@suse.de \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
--cc=guanjunxiong@huawei.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox