dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Xose Vazquez Perez <xose.vazquez@gmail.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH v2 2/2]] multipath-tools: inform that regex can be used in vendor, product, .revision and bl_product
Date: Sat, 6 Aug 2016 01:23:16 +0200	[thread overview]
Message-ID: <e32c64d6-e36b-8e83-dff1-244425d4f25d@gmail.com> (raw)
In-Reply-To: <1470332641-11282-1-git-send-email-xose.vazquez@gmail.com>

On 08/04/2016 07:44 PM, Xose Vazquez Perez wrote:

Please, DROP also this one(v2). Thanks.
v3 is coming.

> Right now they are too wide regex, for example: "HITACHI"/"DF" or "SGI"/"IS".
> It should be used more extensively, at least, in product-ID.
> As I did in 34e345e8
> 
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  libmultipath/hwtable.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 6180751..797ea45 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -868,6 +868,7 @@ static struct hwentry default_hw[] = {
>  	 * Keep only mandatory and modified attributes.
>  	 * Attributes with default values must be removed.
>  	 * .vendor and .product are mandatory, all other are optional.
> +	 * POSIX regex can be used in .vendor, .product, .revision and .bl_product
>  	 *
>  	 * COMPANY_NAME
>  	 *
> 

      reply	other threads:[~2016-08-05 23:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04 17:44 [PATCH v2 2/2]] multipath-tools: inform that regex can be used in vendor, product, .revision and bl_product Xose Vazquez Perez
2016-08-05 23:23 ` Xose Vazquez Perez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e32c64d6-e36b-8e83-dff1-244425d4f25d@gmail.com \
    --to=xose.vazquez@gmail.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).