* [PATCH v2 2/2]] multipath-tools: inform that regex can be used in vendor, product, .revision and bl_product
@ 2016-08-04 17:44 Xose Vazquez Perez
2016-08-05 23:23 ` Xose Vazquez Perez
0 siblings, 1 reply; 2+ messages in thread
From: Xose Vazquez Perez @ 2016-08-04 17:44 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
Right now they are too wide regex, for example: "HITACHI"/"DF" or "SGI"/"IS".
It should be used more extensively, at least, in product-ID.
As I did in 34e345e8
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 6180751..797ea45 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -868,6 +868,7 @@ static struct hwentry default_hw[] = {
* Keep only mandatory and modified attributes.
* Attributes with default values must be removed.
* .vendor and .product are mandatory, all other are optional.
+ * POSIX regex can be used in .vendor, .product, .revision and .bl_product
*
* COMPANY_NAME
*
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2 2/2]] multipath-tools: inform that regex can be used in vendor, product, .revision and bl_product
2016-08-04 17:44 [PATCH v2 2/2]] multipath-tools: inform that regex can be used in vendor, product, .revision and bl_product Xose Vazquez Perez
@ 2016-08-05 23:23 ` Xose Vazquez Perez
0 siblings, 0 replies; 2+ messages in thread
From: Xose Vazquez Perez @ 2016-08-05 23:23 UTC (permalink / raw)
Cc: device-mapper development
On 08/04/2016 07:44 PM, Xose Vazquez Perez wrote:
Please, DROP also this one(v2). Thanks.
v3 is coming.
> Right now they are too wide regex, for example: "HITACHI"/"DF" or "SGI"/"IS".
> It should be used more extensively, at least, in product-ID.
> As I did in 34e345e8
>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> libmultipath/hwtable.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 6180751..797ea45 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -868,6 +868,7 @@ static struct hwentry default_hw[] = {
> * Keep only mandatory and modified attributes.
> * Attributes with default values must be removed.
> * .vendor and .product are mandatory, all other are optional.
> + * POSIX regex can be used in .vendor, .product, .revision and .bl_product
> *
> * COMPANY_NAME
> *
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-05 23:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-04 17:44 [PATCH v2 2/2]] multipath-tools: inform that regex can be used in vendor, product, .revision and bl_product Xose Vazquez Perez
2016-08-05 23:23 ` Xose Vazquez Perez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).